You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/01/21 14:50:20 UTC

[GitHub] [knox] smolnar82 commented on a change in pull request #398: KNOX-2530 - Support qualifying service params for CM discovery control

smolnar82 commented on a change in pull request #398:
URL: https://github.com/apache/knox/pull/398#discussion_r561938097



##########
File path: gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ServiceModel.java
##########
@@ -37,6 +37,9 @@
   private final String roleType;
   private final String serviceUrl;
 
+  // Metadata for the model object, which is not directly from the service or role configuration
+  private final Map<String, String> modelProperties = new ConcurrentHashMap<>();

Review comment:
       I'm wondering if `qualifyingServiceParameters` would be a better name for this field?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org