You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/09/30 14:49:33 UTC
[GitHub] couchdb-fauxton pull request #782: Encoding blerg
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/782
Encoding blerg
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton encoding-blerg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/782.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #782
----
commit 172ef3148d6f8ebc7b012ad6a50f4a4e046b0a08
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-09-30T11:49:24Z
add failing test
This reverts commit ceccc8e46be797304ba89a2fd1e2275531a2a08e.
commit 4a51db8f7abe79b8de405614d38685b450816ccf
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-09-26T14:50:54Z
remove leagcy data-size property handling
CouchDB 2 data size is always available in CouchDB 2
commit a7fdf7f2edbe28c9020107c7f52b09d31b622bf8
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-09-30T14:31:47Z
fix database list links
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding blerg
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
@garrensmith yes, those are existing issues in the documents section we would have to fix in the future, too.
they are also on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: [WIP] Encoding blerg
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
note to self: clicktest db page, create new db
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding blerg
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
ok then I'm +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #782: Encoding issues: fix for database names a...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding issues: fix for database names and refa...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
Need to check the new replication section before merging. Or just after.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding issues: fix for database names and refa...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
If I click on a shared db's database I get `base.js:243 Uncaught TypeError: Cannot read property 'server' of undefined(\u2026)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding issues: fix for database names and refa...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
If I click on the x icon in shared db's I get `components.react.jsx:213 Uncaught TypeError: Cannot read property 'get' of undefined(\u2026)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding blerg
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
```
this fix for encoded database names also includes a big refactor of the database page, pulling logic out of the views and gets rid of backbone models
- no backbone models for the db list any more
- replaces the jquery tooltips on the db list with react tooltips
- avoiding safeURLName which is broken by design
- no method calls on passed data in views any more (e.g. `{this.props.db.get('name')}` - focus on plain JSON data from flux stores
```
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #782: Encoding blerg
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/782
this fix for encoded database names also includes a big refactor of the database page, pulling logic out of the views and getting rid of backbone models
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---