You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/19 13:47:56 UTC

[GitHub] [lucene] mayya-sharipova commented on pull request #11784: NeighborArray is now fixed size

mayya-sharipova commented on PR #11784:
URL: https://github.com/apache/lucene/pull/11784#issuecomment-1251045793

   @msokolov Thanks for tackling this. I was also thinking to remove `NeighborArray` of resizing, which makes logic simplier.
   
   I was thinking a better approach would be to leave it to `NeighborArray` users to define `maxSize`, and not add +1  in the `NeighborArray` class itself as this PR suggests. For example, [OnHeapHnswGraph](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java#L62-L66) already adds +1 when creating `NeighborArray`.
   
   What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org