You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/16 15:01:53 UTC

[GitHub] [tvm] ashutosh-arm commented on a diff in pull request #13407: [ACL] Enable int8 data type in QNN ADD

ashutosh-arm commented on code in PR #13407:
URL: https://github.com/apache/tvm/pull/13407#discussion_r1024123380


##########
src/runtime/contrib/arm_compute_lib/acl_utils.cc:
##########
@@ -130,6 +130,8 @@ arm_compute::DataType MakeACLDataType(const DLDataType& data_type) {
     return arm_compute::DataType::F32;
   } else if (data_type.code == DLDataTypeCode::kDLUInt && data_type.bits == 8) {
     return arm_compute::DataType::QASYMM8;
+  } else if (data_type.code == DLDataTypeCode::kDLInt && data_type.bits == 8) {
+    return arm_compute::DataType::QASYMM8_SIGNED;

Review Comment:
   Just curious why only asymmetric dtype is supported?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org