You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/24 16:00:23 UTC
[GitHub] [spark] Eric5553 opened a new pull request #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Eric5553 opened a new pull request #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685
### What changes were proposed in this pull request?
When EXPLAIN sql query, the generated alias shouldn't include expr/attribute id. This will provide better readability of Explain results. This is a follow-up to address #27368 (comment).
**Before**
```
(7) HashAggregate [codegen id : 2]
Input [2]: [key#x, max#x]
Keys [1]: [key#x]
Functions [1]: [max(val#x)]
Aggregate Attributes [1]: [max(val#x)#x]
Results [2]: [key#x, max(val#x)#x AS max(val)#x]
```
**After**
```
(7) HashAggregate [codegen id : 2]
Input [2]: [key, max]
Keys [1]: [key]
Functions [1]: [max(val)]
Aggregate Attributes [1]: [max(val)]
Results [2]: [key, max(val) AS max(val)]
```
### Why are the changes needed?
Provide better readability for Explain result
### Does this PR introduce any user-facing change?
Update Explain result to a better format
### How was this patch tested?
Update existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596603564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24301/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593738987
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596608833
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593633182
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119179/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-600118025
**[Test build #119928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119928/testReport)** for PR 27685 at commit [`10da2c5`](https://github.com/apache/spark/commit/10da2c516cd4f4ff4e4b77810df4324178108c34).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590561025
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596936214
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119597/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590435151
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590404769
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23625/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590436062
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599902902
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596304802
**[Test build #119547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119547/testReport)** for PR 27685 at commit [`659e7c2`](https://github.com/apache/spark/commit/659e7c2db423e283bd6706aabde813cc5be1fd01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-597051924
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590560276
**[Test build #118880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118880/testReport)** for PR 27685 at commit [`3cf84d2`](https://github.com/apache/spark/commit/3cf84d29f13ed37b92ef4245a2395bee3ef19ea7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590436074
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23629/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-603618760
@cloud-fan @gatorsmile @maryannxue Would you please help review this PR? Thanks so much :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590561025
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590526474
**[Test build #118876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118876/testReport)** for PR 27685 at commit [`3cf84d2`](https://github.com/apache/spark/commit/3cf84d29f13ed37b92ef4245a2395bee3ef19ea7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593780767
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596875170
**[Test build #119597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119597/testReport)** for PR 27685 at commit [`b74c500`](https://github.com/apache/spark/commit/b74c5006a6880773f18507f6b46a1d5674cf7dd4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593864382
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23959/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596602661
**[Test build #119570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119570/testReport)** for PR 27685 at commit [`51bb46a`](https://github.com/apache/spark/commit/51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593995057
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611581074
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25728/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-597051924
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596611946
**[Test build #119573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119573/testReport)** for PR 27685 at commit [`51bb46a`](https://github.com/apache/spark/commit/51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611580344
**[Test build #121037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121037/testReport)** for PR 27685 at commit [`c7daaa6`](https://github.com/apache/spark/commit/c7daaa6543a51dbd83d56b56030d0d0b4755cb56).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389552294
##########
File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-select_having.sql.out
##########
@@ -143,7 +143,7 @@ SELECT udf(a) FROM test_having HAVING udf(min(a)) < udf(max(a))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-grouping expressions sequence is empty, and 'spark_catalog.default.test_having.`a`' is not an aggregate function. Wrap '(min(spark_catalog.default.test_having.`a`) AS `min(a#x)`, max(spark_catalog.default.test_having.`a`) AS `max(a#x)`)' in windowing function(s) or wrap 'spark_catalog.default.test_having.`a`' in first() (or first_value) if you don't care which value you get.;
+grouping expressions sequence is empty, and 'spark_catalog.default.test_having.`a`' is not an aggregate function. Wrap '(min(spark_catalog.default.test_having.`a`) AS `min(a)`, max(spark_catalog.default.test_having.`a`) AS `max(a)`)' in windowing function(s) or wrap 'spark_catalog.default.test_having.`a`' in first() (or first_value) if you don't care which value you get.;
Review comment:
I think the `flatArgument/flatArgumentsString` is tightly bind with `toString` of `Expression/AggregateExpression`, which will commonly affect all of them. I'll try more to eliminate the impact, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593864382
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23959/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596305121
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596602661
**[Test build #119570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119570/testReport)** for PR 27685 at commit [`51bb46a`](https://github.com/apache/spark/commit/51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389649319
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
+ }
+
// Marks this as final, Expression.verboseString should never be called, and thus shouldn't be
// overridden by concrete classes.
final override def verboseString(maxFields: Int): String = simpleString(maxFields)
override def simpleString(maxFields: Int): String = toString
override def toString: String = prettyName + truncatedString(
- flatArguments.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+ flatArgumentStrings.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+
+ def argumentString: String = toString
Review comment:
is it possible to only add one method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611580150
Updated. Thanks so much for helping maintain the PR ! @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596358191
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596359506
cc @cloud-fan @gatorsmile @maropu @maryannxue , thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592273112
**[Test build #119063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119063/testReport)** for PR 27685 at commit [`8238b2a`](https://github.com/apache/spark/commit/8238b2aa1df5a232a0880c4625726a846d9927db).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-600119355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119928/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389546688
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
Review comment:
Actually I tried `arg.toString` first, but there is one testcase got `NullPointerException`. Thus I use `s"$arg"` to avoid the `null` case. Do we have other proper ways to solve this? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596358201
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119547/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593819585
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389649319
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
+ }
+
// Marks this as final, Expression.verboseString should never be called, and thus shouldn't be
// overridden by concrete classes.
final override def verboseString(maxFields: Int): String = simpleString(maxFields)
override def simpleString(maxFields: Int): String = toString
override def toString: String = prettyName + truncatedString(
- flatArguments.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+ flatArgumentStrings.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+
+ def argumentString: String = toString
Review comment:
is it possible to only add one method? I'm worried about adding to many methods to the framework.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596935634
**[Test build #119597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119597/testReport)** for PR 27685 at commit [`b74c500`](https://github.com/apache/spark/commit/b74c5006a6880773f18507f6b46a1d5674cf7dd4).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592273383
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596875542
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592273389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23808/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593819590
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119203/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389501459
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
Review comment:
nit: `s"$arg"` -> `arg.toString` along with `e.argumentString`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389570584
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
Review comment:
Ah, ok. Its ok to keep this as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596732918
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592383017
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593995057
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596936208
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593861966
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599902902
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590436062
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593738987
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389501192
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
Review comment:
Can you leave code comments here about what's a difference from `flatArguments`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599902908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24641/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599983956
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611728009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121037/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r386755598
##########
File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out
##########
@@ -65,48 +65,48 @@ struct<plan:string>
(1) Scan parquet default.explain_temp1
-Output [2]: [key#x, val#x]
+Output [2]: [key, val]
Batched: true
Location [not included in comparison]/{warehouse_dir}/explain_temp1]
PushedFilters: [IsNotNull(key), GreaterThan(key,0)]
ReadSchema: struct<key:int,val:int>
(2) ColumnarToRow [codegen id : 1]
-Input [2]: [key#x, val#x]
+Input [2]: [key, val]
(3) Filter [codegen id : 1]
-Input [2]: [key#x, val#x]
-Condition : (isnotnull(key#x) AND (key#x > 0))
+Input [2]: [key, val]
+Condition : (isnotnull(key) AND (key > 0))
(4) Project [codegen id : 1]
-Output [2]: [key#x, val#x]
-Input [2]: [key#x, val#x]
+Output [2]: [key, val]
+Input [2]: [key, val]
(5) HashAggregate [codegen id : 1]
-Input [2]: [key#x, val#x]
-Keys [1]: [key#x]
-Functions [1]: [partial_max(val#x)]
-Aggregate Attributes [1]: [max#x]
-Results [2]: [key#x, max#x]
+Input [2]: [key, val]
+Keys [1]: [key]
+Functions [1]: [partial_max(val)]
+Aggregate Attributes [1]: [max]
+Results [2]: [key, max]
(6) Exchange
-Input [2]: [key#x, max#x]
-Arguments: hashpartitioning(key#x, 4), true, [id=#x]
+Input [2]: [key, max]
+Arguments: hashpartitioning(key, 4), true, [id=#x]
(7) HashAggregate [codegen id : 2]
-Input [2]: [key#x, max#x]
-Keys [1]: [key#x]
-Functions [1]: [max(val#x)]
-Aggregate Attributes [1]: [max(val#x)#x]
Review comment:
@cloud-fan I've re-implemented to only remove the auto-generated Attrids I think. Would you please help review again? Thanks so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596687135
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119570/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593639905
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119178/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593633166
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593762818
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593780771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23944/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611728009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121037/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593819585
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590404769
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23625/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593738992
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23938/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611727126
**[Test build #121037 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121037/testReport)** for PR 27685 at commit [`c7daaa6`](https://github.com/apache/spark/commit/c7daaa6543a51dbd83d56b56030d0d0b4755cb56).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596875542
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596358191
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592383022
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119063/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r390087193
##########
File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-select_having.sql.out
##########
@@ -143,7 +143,7 @@ SELECT udf(a) FROM test_having HAVING udf(min(a)) < udf(max(a))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-grouping expressions sequence is empty, and 'spark_catalog.default.test_having.`a`' is not an aggregate function. Wrap '(min(spark_catalog.default.test_having.`a`) AS `min(a#x)`, max(spark_catalog.default.test_having.`a`) AS `max(a#x)`)' in windowing function(s) or wrap 'spark_catalog.default.test_having.`a`' in first() (or first_value) if you don't care which value you get.;
+grouping expressions sequence is empty, and 'spark_catalog.default.test_having.`a`' is not an aggregate function. Wrap '(min(spark_catalog.default.test_having.`a`) AS `min(a)`, max(spark_catalog.default.test_having.`a`) AS `max(a)`)' in windowing function(s) or wrap 'spark_catalog.default.test_having.`a`' in first() (or first_value) if you don't care which value you get.;
Review comment:
The error message explicitly called `map(_.sql)` instead of default `toString`. The `Alias.sql` is using `name` field which has already been formatted by `flatArguments` when constructing `Alias`. So this is also following the `flatArgument` framework.
As the error message is intended to suggest user with a sql snippet, maybe it's better to not includ `#exprId` anyway? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593762715
**[Test build #119198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119198/testReport)** for PR 27685 at commit [`e3b105f`](https://github.com/apache/spark/commit/e3b105f7cbbb264c639fa82a775ed8e7307d5d99).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389546688
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
Review comment:
Actually I tried `arg.toString` first, but there is one null argument testcase got `NullPointerException`. Thus I use `s"$arg"` to avoid the `null` case. Do we have other proper ways to solve this? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599902591
**[Test build #119916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119916/testReport)** for PR 27685 at commit [`1cbfe49`](https://github.com/apache/spark/commit/1cbfe49a92f22b2203097a98d6110985b39f4281).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592273112
**[Test build #119063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119063/testReport)** for PR 27685 at commit [`8238b2a`](https://github.com/apache/spark/commit/8238b2aa1df5a232a0880c4625726a846d9927db).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590561034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118880/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611580344
**[Test build #121037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121037/testReport)** for PR 27685 at commit [`c7daaa6`](https://github.com/apache/spark/commit/c7daaa6543a51dbd83d56b56030d0d0b4755cb56).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593638613
**[Test build #119178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119178/testReport)** for PR 27685 at commit [`85f2f01`](https://github.com/apache/spark/commit/85f2f01e682d79cfd5603751462b94d1ff1b17b1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593632764
**[Test build #119179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119179/testReport)** for PR 27685 at commit [`85f2f01`](https://github.com/apache/spark/commit/85f2f01e682d79cfd5603751462b94d1ff1b17b1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599983956
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596305125
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24279/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593639892
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593819410
**[Test build #119203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119203/testReport)** for PR 27685 at commit [`e6df5d9`](https://github.com/apache/spark/commit/e6df5d99f906d76cae4b0314ca5db3a6c34b344f).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-597051931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119607/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596612988
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593782532
**[Test build #119203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119203/testReport)** for PR 27685 at commit [`e6df5d9`](https://github.com/apache/spark/commit/e6df5d99f906d76cae4b0314ca5db3a6c34b344f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596936208
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596608833
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596305121
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596875548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24327/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592383022
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119063/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r386008536
##########
File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out
##########
@@ -65,48 +65,48 @@ struct<plan:string>
(1) Scan parquet default.explain_temp1
-Output [2]: [key#x, val#x]
+Output [2]: [key, val]
Batched: true
Location [not included in comparison]/{warehouse_dir}/explain_temp1]
PushedFilters: [IsNotNull(key), GreaterThan(key,0)]
ReadSchema: struct<key:int,val:int>
(2) ColumnarToRow [codegen id : 1]
-Input [2]: [key#x, val#x]
+Input [2]: [key, val]
(3) Filter [codegen id : 1]
-Input [2]: [key#x, val#x]
-Condition : (isnotnull(key#x) AND (key#x > 0))
+Input [2]: [key, val]
+Condition : (isnotnull(key) AND (key > 0))
(4) Project [codegen id : 1]
-Output [2]: [key#x, val#x]
-Input [2]: [key#x, val#x]
+Output [2]: [key, val]
+Input [2]: [key, val]
(5) HashAggregate [codegen id : 1]
-Input [2]: [key#x, val#x]
-Keys [1]: [key#x]
-Functions [1]: [partial_max(val#x)]
-Aggregate Attributes [1]: [max#x]
-Results [2]: [key#x, max#x]
+Input [2]: [key, val]
+Keys [1]: [key]
+Functions [1]: [partial_max(val)]
+Aggregate Attributes [1]: [max]
+Results [2]: [key, max]
(6) Exchange
-Input [2]: [key#x, max#x]
-Arguments: hashpartitioning(key#x, 4), true, [id=#x]
+Input [2]: [key, max]
+Arguments: hashpartitioning(key, 4), true, [id=#x]
(7) HashAggregate [codegen id : 2]
-Input [2]: [key#x, max#x]
-Keys [1]: [key#x]
-Functions [1]: [max(val#x)]
-Aggregate Attributes [1]: [max(val#x)#x]
Review comment:
I see. Thanks for the review :-)
The common modification in `AttributeReference` will also remove the `#` in `[max(val)#x]`. I'm trying to pin point to the exact creation place of auto-generated `AttributeReference` name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593780771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23944/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611581063
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389772098
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
+ }
+
// Marks this as final, Expression.verboseString should never be called, and thus shouldn't be
// overridden by concrete classes.
final override def verboseString(maxFields: Int): String = simpleString(maxFields)
override def simpleString(maxFields: Int): String = toString
override def toString: String = prettyName + truncatedString(
- flatArguments.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+ flatArgumentStrings.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+
+ def argumentString: String = toString
Review comment:
IMO, the `argumentString` is needed because `AttributeReference` already overwrite `toString`, thus we need the new abstract string function to switch to non-exprid format. For `flatArgumentStrings`, it only have two callers. I refactored the `toAggString` of `AggregateFunction`, then we don't need to add the method `flatArgumentStrings` in `Expression` but just implement it within `toString`. See commit 51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99. @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593633166
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389772098
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
+ case e: Expression => e.argumentString
+ case arg => s"$arg"
+ }
+
// Marks this as final, Expression.verboseString should never be called, and thus shouldn't be
// overridden by concrete classes.
final override def verboseString(maxFields: Int): String = simpleString(maxFields)
override def simpleString(maxFields: Int): String = toString
override def toString: String = prettyName + truncatedString(
- flatArguments.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+ flatArgumentStrings.toSeq, "(", ", ", ")", SQLConf.get.maxToStringFields)
+
+ def argumentString: String = toString
Review comment:
IMO, the `argumentString` is needed because `AttributeReference` already overwrite `toString`, thus we need the new abstract string function to switch to non-exprid format. For `flatArgumentStrings`, it only have two callers. I refactored the `toAggString` of `AggregateFunction`, then we don't need to add the method `flatArgumentStrings` in `Expression` but just implement it within `toString`. See commit b74c5006a6880773f18507f6b46a1d5674cf7dd4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590404760
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599910666
**[Test build #119916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119916/testReport)** for PR 27685 at commit [`1cbfe49`](https://github.com/apache/spark/commit/1cbfe49a92f22b2203097a98d6110985b39f4281).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596612988
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596613003
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24304/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593738670
**[Test build #119198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119198/testReport)** for PR 27685 at commit [`e3b105f`](https://github.com/apache/spark/commit/e3b105f7cbbb264c639fa82a775ed8e7307d5d99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599902908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24641/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593762824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119198/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593633182
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119179/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596732926
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119573/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-600120562
@cloud-fan Would you please help review the latest change? Thanks so much :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593493030
**[Test build #119178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119178/testReport)** for PR 27685 at commit [`85f2f01`](https://github.com/apache/spark/commit/85f2f01e682d79cfd5603751462b94d1ff1b17b1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27685: [SPARK-30940][SQL] Remove
attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611398937
@Eric5553 Could you resolve the conflict?
@cloud-fan Could you do a final check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599910733
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119916/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593639905
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119178/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593819590
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119203/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389501192
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -265,14 +265,21 @@ abstract class Expression extends TreeNode[Expression] {
case single => single :: Nil
}
+ protected def flatArgumentStrings: Iterator[String] = flatArguments.map {
Review comment:
Can you leave code comments here about what's a difference from `flatArguments`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593863650
**[Test build #119220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119220/testReport)** for PR 27685 at commit [`e6df5d9`](https://github.com/apache/spark/commit/e6df5d99f906d76cae4b0314ca5db3a6c34b344f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611581063
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593782532
**[Test build #119203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119203/testReport)** for PR 27685 at commit [`e6df5d9`](https://github.com/apache/spark/commit/e6df5d99f906d76cae4b0314ca5db3a6c34b344f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590436074
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23629/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592273383
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596357719
**[Test build #119547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119547/testReport)** for PR 27685 at commit [`659e7c2`](https://github.com/apache/spark/commit/659e7c2db423e283bd6706aabde813cc5be1fd01).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599902591
**[Test build #119916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119916/testReport)** for PR 27685 at commit [`1cbfe49`](https://github.com/apache/spark/commit/1cbfe49a92f22b2203097a98d6110985b39f4281).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593993920
**[Test build #119220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119220/testReport)** for PR 27685 at commit [`e6df5d9`](https://github.com/apache/spark/commit/e6df5d99f906d76cae4b0314ca5db3a6c34b344f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599910725
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596603564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24301/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593493784
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23920/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611581074
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25728/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r385683494
##########
File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out
##########
@@ -65,48 +65,48 @@ struct<plan:string>
(1) Scan parquet default.explain_temp1
-Output [2]: [key#x, val#x]
+Output [2]: [key, val]
Batched: true
Location [not included in comparison]/{warehouse_dir}/explain_temp1]
PushedFilters: [IsNotNull(key), GreaterThan(key,0)]
ReadSchema: struct<key:int,val:int>
(2) ColumnarToRow [codegen id : 1]
-Input [2]: [key#x, val#x]
+Input [2]: [key, val]
(3) Filter [codegen id : 1]
-Input [2]: [key#x, val#x]
-Condition : (isnotnull(key#x) AND (key#x > 0))
+Input [2]: [key, val]
+Condition : (isnotnull(key) AND (key > 0))
(4) Project [codegen id : 1]
-Output [2]: [key#x, val#x]
-Input [2]: [key#x, val#x]
+Output [2]: [key, val]
+Input [2]: [key, val]
(5) HashAggregate [codegen id : 1]
-Input [2]: [key#x, val#x]
-Keys [1]: [key#x]
-Functions [1]: [partial_max(val#x)]
-Aggregate Attributes [1]: [max#x]
-Results [2]: [key#x, max#x]
+Input [2]: [key, val]
+Keys [1]: [key]
+Functions [1]: [partial_max(val)]
+Aggregate Attributes [1]: [max]
+Results [2]: [key, max]
(6) Exchange
-Input [2]: [key#x, max#x]
-Arguments: hashpartitioning(key#x, 4), true, [id=#x]
+Input [2]: [key, max]
+Arguments: hashpartitioning(key, 4), true, [id=#x]
(7) HashAggregate [codegen id : 2]
-Input [2]: [key#x, max#x]
-Keys [1]: [key#x]
-Functions [1]: [max(val#x)]
-Aggregate Attributes [1]: [max(val#x)#x]
Review comment:
It's still useful to have the attr id as the name can be duplicated
```
scala> sql("select 1 as a, 2 as a").explain
== Physical Plan ==
*(1) Project [1 AS a#53, 2 AS a#54]
+- Scan OneRowRelation[]
```
I think we should only remove the attr id from the auto-generated alias name. e.g. this should be `[max(val)#x]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596936214
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119597/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590527236
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596687118
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593493771
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593493784
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23920/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599910725
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596875548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24327/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599983961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24653/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-600119355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119928/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593863650
**[Test build #119220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119220/testReport)** for PR 27685 at commit [`e6df5d9`](https://github.com/apache/spark/commit/e6df5d99f906d76cae4b0314ca5db3a6c34b344f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599983399
**[Test build #119928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119928/testReport)** for PR 27685 at commit [`10da2c5`](https://github.com/apache/spark/commit/10da2c516cd4f4ff4e4b77810df4324178108c34).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593995066
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119220/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-600119342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-600119342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599983399
**[Test build #119928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119928/testReport)** for PR 27685 at commit [`10da2c5`](https://github.com/apache/spark/commit/10da2c516cd4f4ff4e4b77810df4324178108c34).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596732515
**[Test build #119573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119573/testReport)** for PR 27685 at commit [`51bb46a`](https://github.com/apache/spark/commit/51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590403918
**[Test build #118876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118876/testReport)** for PR 27685 at commit [`3cf84d2`](https://github.com/apache/spark/commit/3cf84d29f13ed37b92ef4245a2395bee3ef19ea7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596942858
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596603546
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590527244
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118876/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611728000
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593864369
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590403918
**[Test build #118876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118876/testReport)** for PR 27685 at commit [`3cf84d2`](https://github.com/apache/spark/commit/3cf84d29f13ed37b92ef4245a2395bee3ef19ea7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596358201
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119547/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-597051931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119607/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-597051042
**[Test build #119607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119607/testReport)** for PR 27685 at commit [`cee32e4`](https://github.com/apache/spark/commit/cee32e486706a1294f1d50ad0cf92e55853aeb90).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r389503496
##########
File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-select_having.sql.out
##########
@@ -143,7 +143,7 @@ SELECT udf(a) FROM test_having HAVING udf(min(a)) < udf(max(a))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-grouping expressions sequence is empty, and 'spark_catalog.default.test_having.`a`' is not an aggregate function. Wrap '(min(spark_catalog.default.test_having.`a`) AS `min(a#x)`, max(spark_catalog.default.test_having.`a`) AS `max(a#x)`)' in windowing function(s) or wrap 'spark_catalog.default.test_having.`a`' in first() (or first_value) if you don't care which value you get.;
+grouping expressions sequence is empty, and 'spark_catalog.default.test_having.`a`' is not an aggregate function. Wrap '(min(spark_catalog.default.test_having.`a`) AS `min(a)`, max(spark_catalog.default.test_having.`a`) AS `max(a)`)' in windowing function(s) or wrap 'spark_catalog.default.test_having.`a`' in first() (or first_value) if you don't care which value you get.;
Review comment:
We need to hide ids even in error messages, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593762824
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119198/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596305125
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24279/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593639892
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593780767
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593738670
**[Test build #119198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119198/testReport)** for PR 27685 at commit [`e3b105f`](https://github.com/apache/spark/commit/e3b105f7cbbb264c639fa82a775ed8e7307d5d99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593493771
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599910733
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119916/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593522799
**[Test build #119179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119179/testReport)** for PR 27685 at commit [`85f2f01`](https://github.com/apache/spark/commit/85f2f01e682d79cfd5603751462b94d1ff1b17b1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592273389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23808/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on a change in pull request #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#discussion_r386008536
##########
File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out
##########
@@ -65,48 +65,48 @@ struct<plan:string>
(1) Scan parquet default.explain_temp1
-Output [2]: [key#x, val#x]
+Output [2]: [key, val]
Batched: true
Location [not included in comparison]/{warehouse_dir}/explain_temp1]
PushedFilters: [IsNotNull(key), GreaterThan(key,0)]
ReadSchema: struct<key:int,val:int>
(2) ColumnarToRow [codegen id : 1]
-Input [2]: [key#x, val#x]
+Input [2]: [key, val]
(3) Filter [codegen id : 1]
-Input [2]: [key#x, val#x]
-Condition : (isnotnull(key#x) AND (key#x > 0))
+Input [2]: [key, val]
+Condition : (isnotnull(key) AND (key > 0))
(4) Project [codegen id : 1]
-Output [2]: [key#x, val#x]
-Input [2]: [key#x, val#x]
+Output [2]: [key, val]
+Input [2]: [key, val]
(5) HashAggregate [codegen id : 1]
-Input [2]: [key#x, val#x]
-Keys [1]: [key#x]
-Functions [1]: [partial_max(val#x)]
-Aggregate Attributes [1]: [max#x]
-Results [2]: [key#x, max#x]
+Input [2]: [key, val]
+Keys [1]: [key]
+Functions [1]: [partial_max(val)]
+Aggregate Attributes [1]: [max]
+Results [2]: [key, max]
(6) Exchange
-Input [2]: [key#x, max#x]
-Arguments: hashpartitioning(key#x, 4), true, [id=#x]
+Input [2]: [key, max]
+Arguments: hashpartitioning(key, 4), true, [id=#x]
(7) HashAggregate [codegen id : 2]
-Input [2]: [key#x, max#x]
-Keys [1]: [key#x]
-Functions [1]: [max(val#x)]
-Aggregate Attributes [1]: [max(val#x)#x]
Review comment:
I see. Thanks for the review :-)
The common modification in `AttributeReference` will also remove the `#` in `[max(val)#x]`. I'm trying to pin point to the exact creation time of auto-generated `AttributeReference` name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596942507
**[Test build #119607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119607/testReport)** for PR 27685 at commit [`cee32e4`](https://github.com/apache/spark/commit/cee32e486706a1294f1d50ad0cf92e55853aeb90).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590561034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118880/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590527236
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590527244
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118876/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590439719
**[Test build #118880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118880/testReport)** for PR 27685 at commit [`3cf84d2`](https://github.com/apache/spark/commit/3cf84d29f13ed37b92ef4245a2395bee3ef19ea7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592383017
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593522799
**[Test build #119179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119179/testReport)** for PR 27685 at commit [`85f2f01`](https://github.com/apache/spark/commit/85f2f01e682d79cfd5603751462b94d1ff1b17b1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596942507
**[Test build #119607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119607/testReport)** for PR 27685 at commit [`cee32e4`](https://github.com/apache/spark/commit/cee32e486706a1294f1d50ad0cf92e55853aeb90).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593493030
**[Test build #119178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119178/testReport)** for PR 27685 at commit [`85f2f01`](https://github.com/apache/spark/commit/85f2f01e682d79cfd5603751462b94d1ff1b17b1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593995066
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119220/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596304802
**[Test build #119547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119547/testReport)** for PR 27685 at commit [`659e7c2`](https://github.com/apache/spark/commit/659e7c2db423e283bd6706aabde813cc5be1fd01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596603546
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593762818
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590404760
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593738992
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23938/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-599983961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24653/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596942865
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24336/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596687118
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596686838
**[Test build #119570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119570/testReport)** for PR 27685 at commit [`51bb46a`](https://github.com/apache/spark/commit/51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-611728000
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590435151
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596942865
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24336/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596942858
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596611946
**[Test build #119573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119573/testReport)** for PR 27685 at commit [`51bb46a`](https://github.com/apache/spark/commit/51bb46aea0ae7a4c74c6e1026b173cafbfd2ca99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592382391
**[Test build #119063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119063/testReport)** for PR 27685 at commit [`8238b2a`](https://github.com/apache/spark/commit/8238b2aa1df5a232a0880c4625726a846d9927db).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596687135
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119570/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27685: [SPARK-30940][SQL]
Remove attributeId in auto-generated arguments when Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596732926
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119573/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-593864369
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-590439719
**[Test build #118880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118880/testReport)** for PR 27685 at commit [`3cf84d2`](https://github.com/apache/spark/commit/3cf84d29f13ed37b92ef4245a2395bee3ef19ea7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596732918
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eric5553 commented on issue #27685: [SPARK-30940][SQL]
Remove meaningless attributeId when Explain SQL query
Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27685: [SPARK-30940][SQL] Remove meaningless attributeId when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-592443233
@cloud-fan Would you please help review this? Thanks so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596613003
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24304/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27685:
[SPARK-30940][SQL] Remove attributeId in auto-generated arguments when
Explain SQL query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27685: [SPARK-30940][SQL] Remove attributeId in auto-generated arguments when Explain SQL query
URL: https://github.com/apache/spark/pull/27685#issuecomment-596875170
**[Test build #119597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119597/testReport)** for PR 27685 at commit [`b74c500`](https://github.com/apache/spark/commit/b74c5006a6880773f18507f6b46a1d5674cf7dd4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org