You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/14 13:12:39 UTC
[GitHub] [beam] AydarZaynutdinov opened a new pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
AydarZaynutdinov opened a new pull request #15721:
URL: https://github.com/apache/beam/pull/15721
Add Redis implementation of Cache.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r732427178
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
+ SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error
+
+ // SetExpTime adds expiration time of the pipeline to cache by pipelineId.
+ SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error
+}
+
+// NewCache returns new cache to save and read value
+func NewCache(ctx context.Context, cacheType string) (Cache, error) {
Review comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r732328829
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
Review comment:
Can you add a comment here detailing that these are the kinds of values and their types please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
damondouglas commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r731970681
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
+ SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error
+
+ // SetExpTime adds expiration time of the pipeline to cache by pipelineId.
+ SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error
+}
+
+// NewCache returns new cache to save and read value
+func NewCache(ctx context.Context, cacheType string) (Cache, error) {
Review comment:
May we consider just naming this to `New`?
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
+ SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error
+
+ // SetExpTime adds expiration time of the pipeline to cache by pipelineId.
+ SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error
+}
+
+// NewCache returns new cache to save and read value
+func NewCache(ctx context.Context, cacheType string) (Cache, error) {
+ switch cacheType {
+ case "remote":
+ return newRedisCache(ctx, os.Getenv("remote_cache_address"))
Review comment:
What do you think about leaving the `Cache` interface in the `cache` package and additionally creating a local folder and redis folder. In each of the local and redis folders have a New method that defines the constructor-like parameters needed for each? The design pattern allows knowledge by the instantiator of the cache but the usage of the cache by the service should only receive the interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r738043515
##########
File path: playground/backend/internal/cache/redis/redis_cache.go
##########
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package redis
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api/v1"
+ "beam.apache.org/playground/backend/internal/cache"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "log"
Review comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
damondouglas commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r729889130
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
Review comment:
What if we did this pattern? The outcome is that all the methods available to `redis.Client` are automatically bound to our struct but we can also bind our own new methods. It was one of the rare occurences for me personally where I found value in this extends-like pattern in go.
```
type RedisCache struct {
*redis.Client
}
```
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
Review comment:
These methods were challenging for me to read. My comment is applied to `ping` but it applies to `exists`, `expire`, etc. May we consider either binding the methods or doing the "extend" pattern commented above?
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
+ return redisClient.Ping(ctx).Result()
+}
+
+// check if pipelineId exists as Redis key
+var exists = func(redisClient *redis.Client, ctx context.Context, pipelineId uuid.UUID) (int64, error) {
+ return redisClient.Exists(ctx, pipelineId.String()).Result()
+}
+
+// set expiration time for key
+var expire = func(redisClient *redis.Client, ctx context.Context, key string, expTime time.Duration) (bool, error) {
+ return redisClient.Expire(ctx, key, expTime).Result()
+}
+
+// put encoded value to {key}:{encoded subKey} structure
+var hSet = func(redisClient *redis.Client, ctx context.Context, key string, subKeyMarsh, valueMarsh []byte) (int64, error) {
+ return redisClient.HSet(ctx, key, subKeyMarsh, valueMarsh).Result()
+}
+
+// receive value from {key}:{subKey} structure
+var hGet = func(redisClient *redis.Client, ctx context.Context, key, subKey string) (string, error) {
+ return redisClient.HGet(ctx, key, subKey).Result()
+}
+
+// newRedisCache returns Redis implementation of Cache interface.
+// In case of problem with connection to Redis returns error.
+func newRedisCache(ctx context.Context, addr string) (*RedisCache, error) {
Review comment:
How would a user of this package instantiate `RedisCache` if this is not public? Also this constructor seems more restrictive than the original redis client.
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
+ return redisClient.Ping(ctx).Result()
+}
+
+// check if pipelineId exists as Redis key
+var exists = func(redisClient *redis.Client, ctx context.Context, pipelineId uuid.UUID) (int64, error) {
+ return redisClient.Exists(ctx, pipelineId.String()).Result()
+}
+
+// set expiration time for key
+var expire = func(redisClient *redis.Client, ctx context.Context, key string, expTime time.Duration) (bool, error) {
+ return redisClient.Expire(ctx, key, expTime).Result()
+}
+
+// put encoded value to {key}:{encoded subKey} structure
+var hSet = func(redisClient *redis.Client, ctx context.Context, key string, subKeyMarsh, valueMarsh []byte) (int64, error) {
+ return redisClient.HSet(ctx, key, subKeyMarsh, valueMarsh).Result()
+}
+
+// receive value from {key}:{subKey} structure
+var hGet = func(redisClient *redis.Client, ctx context.Context, key, subKey string) (string, error) {
+ return redisClient.HGet(ctx, key, subKey).Result()
+}
+
+// newRedisCache returns Redis implementation of Cache interface.
+// In case of problem with connection to Redis returns error.
+func newRedisCache(ctx context.Context, addr string) (*RedisCache, error) {
+ rc := RedisCache{redisClient: redis.NewClient(&redis.Options{Addr: addr})}
+ _, err := ping(rc.redisClient, ctx)
+ if err != nil {
+ grpclog.Errorf("Redis Cache: connect to Redis: error during Ping operation, err: %s", err.Error())
+ return nil, err
+ }
+ return &rc, nil
+}
+
+func (rc *RedisCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) {
+ marshSubKey, err := json.Marshal(subKey)
+ if err != nil {
+ grpclog.Errorf("Redis Cache: get value: error during marshal subKey: %s, err: %s", subKey, err.Error())
+ return nil, err
+ }
+ value, err := hGet(rc.redisClient, ctx, pipelineId.String(), string(marshSubKey))
+ if err != nil {
+ grpclog.Errorf("Redis Cache: get value: error during HGet operation for key: %s, subKey: %s, err: %s", pipelineId.String(), subKey, err.Error())
+ return nil, err
+ }
+
+ return unmarshalBySubKey(subKey, value)
+}
+
+func (rc *RedisCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error {
+ subKeyMarsh, err := json.Marshal(subKey)
+ if err != nil {
+ grpclog.Errorf("Redis Cache: set value: error during marshal subKey: %s, err: %s", subKey, err.Error())
Review comment:
May we consider just using the `log` library native to go?
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
+ return redisClient.Ping(ctx).Result()
+}
+
+// check if pipelineId exists as Redis key
+var exists = func(redisClient *redis.Client, ctx context.Context, pipelineId uuid.UUID) (int64, error) {
+ return redisClient.Exists(ctx, pipelineId.String()).Result()
+}
+
+// set expiration time for key
+var expire = func(redisClient *redis.Client, ctx context.Context, key string, expTime time.Duration) (bool, error) {
+ return redisClient.Expire(ctx, key, expTime).Result()
+}
+
+// put encoded value to {key}:{encoded subKey} structure
+var hSet = func(redisClient *redis.Client, ctx context.Context, key string, subKeyMarsh, valueMarsh []byte) (int64, error) {
+ return redisClient.HSet(ctx, key, subKeyMarsh, valueMarsh).Result()
+}
+
+// receive value from {key}:{subKey} structure
+var hGet = func(redisClient *redis.Client, ctx context.Context, key, subKey string) (string, error) {
+ return redisClient.HGet(ctx, key, subKey).Result()
+}
+
+// newRedisCache returns Redis implementation of Cache interface.
+// In case of problem with connection to Redis returns error.
+func newRedisCache(ctx context.Context, addr string) (*RedisCache, error) {
Review comment:
I now see with https://github.com/apache/beam/pull/15714/files#diff-c9958b6146b1d7a3cc749646a8807db23e6d2d35bd44ab0b3fb775d6b445e64fR48 how this is intended to be used. Perhaps then it makes sense to not make `RedisCache` public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #15721:
URL: https://github.com/apache/beam/pull/15721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r732329970
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
+ return redisClient.Ping(ctx).Result()
+}
+
+// check if pipelineId exists as Redis key
+var exists = func(redisClient *redis.Client, ctx context.Context, pipelineId uuid.UUID) (int64, error) {
+ return redisClient.Exists(ctx, pipelineId.String()).Result()
+}
+
+// set expiration time for key
+var expire = func(redisClient *redis.Client, ctx context.Context, key string, expTime time.Duration) (bool, error) {
+ return redisClient.Expire(ctx, key, expTime).Result()
+}
+
+// put encoded value to {key}:{encoded subKey} structure
+var hSet = func(redisClient *redis.Client, ctx context.Context, key string, subKeyMarsh, valueMarsh []byte) (int64, error) {
+ return redisClient.HSet(ctx, key, subKeyMarsh, valueMarsh).Result()
+}
+
+// receive value from {key}:{subKey} structure
+var hGet = func(redisClient *redis.Client, ctx context.Context, key, subKey string) (string, error) {
+ return redisClient.HGet(ctx, key, subKey).Result()
+}
+
+// newRedisCache returns Redis implementation of Cache interface.
+// In case of problem with connection to Redis returns error.
+func newRedisCache(ctx context.Context, addr string) (*RedisCache, error) {
Review comment:
yes, let's keep it private since the public constructor is above : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r737848260
##########
File path: playground/backend/internal/cache/redis/redis_cache.go
##########
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package redis
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api/v1"
+ "beam.apache.org/playground/backend/internal/cache"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "log"
Review comment:
let's use our logging library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r732601051
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
+ SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error
+
+ // SetExpTime adds expiration time of the pipeline to cache by pipelineId.
+ SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error
+}
+
+// NewCache returns new cache to save and read value
+func NewCache(ctx context.Context, cacheType string) (Cache, error) {
+ switch cacheType {
+ case "remote":
+ return newRedisCache(ctx, os.Getenv("remote_cache_address"))
Review comment:
Changed.
Now redis's files are placed into `redis` folder (the same with local's files). redis and local implementations have constructors with the name `New`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r732426883
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
Review comment:
Added comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on pull request #15721:
URL: https://github.com/apache/beam/pull/15721#issuecomment-943344286
R: @pabloem
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #15721: [BEAM-13023][Playground] Implement Redis cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
AydarZaynutdinov commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r729921851
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
+ return redisClient.Ping(ctx).Result()
+}
+
+// check if pipelineId exists as Redis key
+var exists = func(redisClient *redis.Client, ctx context.Context, pipelineId uuid.UUID) (int64, error) {
+ return redisClient.Exists(ctx, pipelineId.String()).Result()
+}
+
+// set expiration time for key
+var expire = func(redisClient *redis.Client, ctx context.Context, key string, expTime time.Duration) (bool, error) {
+ return redisClient.Expire(ctx, key, expTime).Result()
+}
+
+// put encoded value to {key}:{encoded subKey} structure
+var hSet = func(redisClient *redis.Client, ctx context.Context, key string, subKeyMarsh, valueMarsh []byte) (int64, error) {
+ return redisClient.HSet(ctx, key, subKeyMarsh, valueMarsh).Result()
+}
+
+// receive value from {key}:{subKey} structure
+var hGet = func(redisClient *redis.Client, ctx context.Context, key, subKey string) (string, error) {
+ return redisClient.HGet(ctx, key, subKey).Result()
+}
+
+// newRedisCache returns Redis implementation of Cache interface.
+// In case of problem with connection to Redis returns error.
+func newRedisCache(ctx context.Context, addr string) (*RedisCache, error) {
Review comment:
So can I keep it as a private method?
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
Review comment:
Changed.
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
Review comment:
Changed.
##########
File path: playground/backend/internal/cache/redis_cache.go
##########
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "context"
+ "encoding/json"
+ "fmt"
+ "github.com/go-redis/redis/v8"
+ "github.com/google/uuid"
+ "google.golang.org/grpc/grpclog"
+ "time"
+)
+
+const defaultExpirationTime = time.Minute * 15
+
+type RedisCache struct {
+ redisClient *redis.Client
+}
+
+// check connection to Redis
+var ping = func(redisClient *redis.Client, ctx context.Context) (string, error) {
+ return redisClient.Ping(ctx).Result()
+}
+
+// check if pipelineId exists as Redis key
+var exists = func(redisClient *redis.Client, ctx context.Context, pipelineId uuid.UUID) (int64, error) {
+ return redisClient.Exists(ctx, pipelineId.String()).Result()
+}
+
+// set expiration time for key
+var expire = func(redisClient *redis.Client, ctx context.Context, key string, expTime time.Duration) (bool, error) {
+ return redisClient.Expire(ctx, key, expTime).Result()
+}
+
+// put encoded value to {key}:{encoded subKey} structure
+var hSet = func(redisClient *redis.Client, ctx context.Context, key string, subKeyMarsh, valueMarsh []byte) (int64, error) {
+ return redisClient.HSet(ctx, key, subKeyMarsh, valueMarsh).Result()
+}
+
+// receive value from {key}:{subKey} structure
+var hGet = func(redisClient *redis.Client, ctx context.Context, key, subKey string) (string, error) {
+ return redisClient.HGet(ctx, key, subKey).Result()
+}
+
+// newRedisCache returns Redis implementation of Cache interface.
+// In case of problem with connection to Redis returns error.
+func newRedisCache(ctx context.Context, addr string) (*RedisCache, error) {
+ rc := RedisCache{redisClient: redis.NewClient(&redis.Options{Addr: addr})}
+ _, err := ping(rc.redisClient, ctx)
+ if err != nil {
+ grpclog.Errorf("Redis Cache: connect to Redis: error during Ping operation, err: %s", err.Error())
+ return nil, err
+ }
+ return &rc, nil
+}
+
+func (rc *RedisCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) {
+ marshSubKey, err := json.Marshal(subKey)
+ if err != nil {
+ grpclog.Errorf("Redis Cache: get value: error during marshal subKey: %s, err: %s", subKey, err.Error())
+ return nil, err
+ }
+ value, err := hGet(rc.redisClient, ctx, pipelineId.String(), string(marshSubKey))
+ if err != nil {
+ grpclog.Errorf("Redis Cache: get value: error during HGet operation for key: %s, subKey: %s, err: %s", pipelineId.String(), subKey, err.Error())
+ return nil, err
+ }
+
+ return unmarshalBySubKey(subKey, value)
+}
+
+func (rc *RedisCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error {
+ subKeyMarsh, err := json.Marshal(subKey)
+ if err != nil {
+ grpclog.Errorf("Redis Cache: set value: error during marshal subKey: %s, err: %s", subKey, err.Error())
Review comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org