You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/16 07:08:15 UTC
[GitHub] shadogray commented on a change in pull request #14078:
[MXNET-14075] repair example,
enable fault tolerant build of R reference manual
shadogray commented on a change in pull request #14078: [MXNET-14075] repair example, enable fault tolerant build of R reference manual
URL: https://github.com/apache/incubator-mxnet/pull/14078#discussion_r257450070
##########
File path: Makefile
##########
@@ -619,8 +620,19 @@ rpkg:
echo "import(Rcpp)" >> R-package/NAMESPACE
R CMD INSTALL R-package
Rscript -e "require(mxnet); mxnet:::mxnet.export('R-package'); warnings()"
- rm R-package/NAMESPACE
+ $(RM) R-package/NAMESPACE
Review comment:
for this Makefile a global remove command is defined, and it is reasonable to make consistent use of it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services