[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6907: Update defaults of max-concurrent-file-group-rewrites to 5

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #6907:
URL: https://github.com/apache/iceberg/pull/6907#discussion_r1115991979


##########
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##########
@@ -76,7 +76,7 @@
    */
   String MAX_CONCURRENT_FILE_GROUP_REWRITES = "max-concurrent-file-group-rewrites";
 
-  int MAX_CONCURRENT_FILE_GROUP_REWRITES_DEFAULT = 1;
+  int MAX_CONCURRENT_FILE_GROUP_REWRITES_DEFAULT = 5;

Review Comment:
   > I support the idea of changing this default as we ask our users to change it in 9/10 cases.
   
   True. Weekly once or twice, I am suggesting users configure it in Iceberg slack. Most of them doesn't read javadoc :( 
   I would love to see this default value getting changed.
   
   +1 for this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org