You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/23 16:53:36 UTC
[GitHub] [airflow] OmerJog commented on a change in pull request #4341:
[AIRFLOW-3537] Add task_definition as templated parameter in AWS ECS Operator
OmerJog commented on a change in pull request #4341: [AIRFLOW-3537] Add task_definition as templated parameter in AWS ECS Operator
URL: https://github.com/apache/airflow/pull/4341#discussion_r306426651
##########
File path: tests/contrib/operators/test_ecs_operator.py
##########
@@ -95,7 +95,7 @@ def test_init(self):
self.aws_hook_mock.assert_called_once_with(aws_conn_id=None)
def test_template_fields_overrides(self):
- self.assertEqual(self.ecs.template_fields, ('overrides',))
Review comment:
@mik-laj Not different than the test in this PR https://github.com/apache/airflow/pull/5490 which was merged. So why hold this PR stale?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services