[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #13853: Fix trim might cause NPE in PropertyUtils

["Radeity (via GitHub)" <gi...@apache.org>]

Radeity commented on code in PR #13853:
URL: https://github.com/apache/dolphinscheduler/pull/13853#discussion_r1156283188


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java:
##########
@@ -88,6 +88,9 @@ public static boolean getResUploadStartupState() {
      * @return property value
      */
     public static String getString(String key) {
+        if (key == null) {

Review Comment:
   May i ask in which scenario will there be a null key?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org