[jira] Commented: (HDFS-119) logSync() may block NameNode forever.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737811#action_12737811 ] 

Hadoop QA commented on HDFS-119:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12414931/HDFS-119.patch
  against trunk revision 799769.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/39/console

This message is automatically generated.

> logSync() may block NameNode forever.
> -------------------------------------
>
>                 Key: HDFS-119
>                 URL: https://issues.apache.org/jira/browse/HDFS-119
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Konstantin Shvachko
>            Assignee: Suresh Srinivas
>             Fix For: 0.21.0
>
>         Attachments: HDFS-119.patch, HDFS-119.patch
>
>
> # {{FSEditLog.logSync()}} first waits until {{isSyncRunning}} is false and then performs syncing to file streams by calling {{EditLogOutputStream.flush()}}.
> If an exception is thrown after {{isSyncRunning}} is set to {{true}} all threads will always wait on this condition.
> An {{IOException}} may be thrown by {{EditLogOutputStream.setReadyToFlush()}} or a {{RuntimeException}} may be thrown by {{EditLogOutputStream.flush()}} or by {{processIOError()}}.
> # The loop that calls {{eStream.flush()}} for multiple {{EditLogOutputStream}}-s is not synchronized, which means that another thread may encounter an error and modify {{editStreams}} by say calling {{processIOError()}}. Then the iterating process in {{logSync()}} will break with {{IndexOutOfBoundException}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.