You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/13 15:31:30 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #20700: fix(releases): docker build on M1 npm run build fails
dpgaspar opened a new pull request, #20700:
URL: https://github.com/apache/superset/pull/20700
### SUMMARY
On M1 testing releases with `./test_run_tarball.sh` fails with:
```
#17 121.9 npm ERR! path /home/superset/apache-superset-2.0.0rc2/superset-frontend/node_modules/puppeteer
#17 121.9 npm ERR! command failed
#17 121.9 npm ERR! command sh -c node install.js
#17 121.9 npm ERR! The chromium binary is not available for arm64.
#17 121.9 npm ERR! If you are on Ubuntu, you can install with:
#17 121.9 npm ERR!
#17 121.9 npm ERR! sudo apt install chromium
#17 121.9 npm ERR!
#17 121.9 npm ERR!
#17 121.9 npm ERR! sudo apt install chromium-browser
#17 121.9 npm ERR!
#17 121.9 npm ERR! /home/superset/apache-superset-2.0.0rc2/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115
#17 121.9 npm ERR! throw new Error();
#17 121.9 npm ERR! ^
#17 121.9 npm ERR!
#17 121.9 npm ERR! Error
#17 121.9 npm ERR! at /home/superset/apache-superset-2.0.0rc2/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115:27
#17 121.9 npm ERR! at FSReqCallback.oncomplete (node:fs:198:21)
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #20700: fix(releases): docker build on M1 npm run build fails
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on code in PR #20700:
URL: https://github.com/apache/superset/pull/20700#discussion_r920239735
##########
RELEASING/Dockerfile.from_local_tarball:
##########
@@ -30,7 +30,7 @@ RUN apt-get install -y apt-transport-https apt-utils
# Install superset dependencies
# https://superset.apache.org/docs/installation/installing-superset-from-scratch
RUN apt-get install -y build-essential libssl-dev \
- libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev
+ libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev chromium
Review Comment:
could be more defensive and add an extra line with:
```
RUN if [ $(arch) == "aarch64" ]; then apt-get install chromium; fi
```
But would add another layer to the container and it should be fine on non M1 also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #20700: fix(releases): docker build on M1 npm run build fails
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on code in PR #20700:
URL: https://github.com/apache/superset/pull/20700#discussion_r920223172
##########
RELEASING/test_run_tarball.sh:
##########
@@ -26,7 +26,7 @@ if [ -z "${SUPERSET_SVN_DEV_PATH}" ]; then
SUPERSET_SVN_DEV_PATH="$HOME/svn/superset_dev"
fi
-if [ ${1} == "local" ]; then
+if [[ -n ${1} ]] && [[ ${1} == "local" ]]; then
Review Comment:
fixes `./test_run_tarball.sh: line 29: [: ==: unary operator expected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #20700: fix(releases): docker build on M1 npm run build fails
Posted by GitBox <gi...@apache.org>.
dpgaspar merged PR #20700:
URL: https://github.com/apache/superset/pull/20700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org