You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by xwq <gi...@git.apache.org> on 2016/04/13 11:11:08 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1931]ODB tool support...
GitHub user xwq opened a pull request:
https://github.com/apache/incubator-trafodion/pull/431
[TRAFODION-1931]ODB tool support windows platform
add Visual Studio project files to support compile odb in windows platform
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xwq/incubator-trafodion TRAFODION-1931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #431
----
commit 15c8c59a5ede4f1ceb6f1faf221303978d6e3a4d
Author: Weiqing Xu <we...@esgyn.cn>
Date: 2016-04-13T09:10:18Z
[TRAFODION-1931]ODB tool support windows platform
add Visual Studio project files to support compile odb in windows platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1931]ODB tool support...
Posted by xwq <gi...@git.apache.org>.
Github user xwq commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/431#discussion_r60185571
--- Diff: .rat-excludes ---
@@ -109,6 +109,9 @@ TCPIPV6_os.*
.ism*
resource.h*
resource.hm*
+odb.sln
+odb.vcxporj*
--- End diff --
Thank you.
I used to want to add "odb.vcxproj*". However I found the next line "odb.vcxproj.*" was enough . So I remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1931]ODB tool support...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/431#discussion_r60092111
--- Diff: .rat-excludes ---
@@ -109,6 +109,9 @@ TCPIPV6_os.*
.ism*
resource.h*
resource.hm*
+odb.sln
+odb.vcxporj*
--- End diff --
Is this line a typo? (I notice that the next line is odb.vcxproj*). I don't see any files that match this pattern. Perhaps we can remove this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1931]ODB tool support...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---