[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3766: object-store: fix handling of AWS profile credentials without expiry

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3766:
URL: https://github.com/apache/arrow-rs/pull/3766#discussion_r1118941179


##########
object_store/src/aws/credential.rs:
##########
@@ -553,18 +553,7 @@ mod profile {
                             store: "S3",
                             source: Box::new(source),
                         })?;
-
-                let t_now = SystemTime::now();
-                let expiry = match c.expiry().and_then(|e| e.duration_since(t_now).ok()) {

Review Comment:
   Yes, but the way it does this breaks credentials that do expire. My suggestion is just to handle the `None` case with an infinite TTL, instead of what this PR currently does which is assign an arbitrary expiry to all credentials



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org