[jira] [Resolved] (AVRO-3173) Rust: fix panic messages in test code

["Ryan Skraba (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Skraba resolved AVRO-3173.
-------------------------------
    Resolution: Fixed

> Rust: fix panic messages in test code
> -------------------------------------
>
>                 Key: AVRO-3173
>                 URL: https://issues.apache.org/jira/browse/AVRO-3173
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>            Reporter: Martin Tzvetanov Grigorov
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Running `cargo test` (Rust 1.53.0) produces the following warnings:
>  
> {code:java}
> warning: panic message is not a string literal
>     --> tests/schema.rs:1173:13
>      |
> 1173 |             e.to_string()
>      |             ^^^^^^^^^^^^^
>      |
>      = note: `#[warn(non_fmt_panic)]` on by default
>      = note: this is no longer accepted in Rust 2021
> help: add a "{}" format string to Display the message
>      |
> 1173 |             "{}", e.to_string()
>      |             ^^^^^warning: 1 warning emitted
>  {code}
>  
> {code:java}
>  warning: panic message is not a string literal
>    --> tests/io.rs:105:13
>     |
> 105 |             format!("value {:?} does not validate schema: {}", value, raw_schema)
>     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     |
>     = note: `#[warn(non_fmt_panic)]` on by default
>     = note: this is no longer accepted in Rust 2021
>     = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
> help: remove the `format!(..)` macro call
>     |
> 105 |             "value {:?} does not validate schema: {}", value, raw_schema
>     |            --                                                          --warning: 1 warning emitted{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)