You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/10/21 11:43:43 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

zjffdu commented on a change in pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#discussion_r733591377



##########
File path: zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java
##########
@@ -81,7 +82,7 @@ public void close() {
   @Override
   public List<NotebookRepoSettingsInfo> getSettings(AuthenticationInfo subject) {
     LOGGER.warn("getSettings is not implemented for HdfsNotebookRepo");
-    return null;
+    return Collections.emptyList();

Review comment:
       Not related to this PR, I think it is time to move these Old NotebookRepo 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org