You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "EMsnap (via GitHub)" <gi...@apache.org> on 2023/03/14 12:45:30 UTC

[GitHub] [inlong] EMsnap opened a new pull request, #7610: [INLONG-7609][Sort][Feature] Add audit for kafka source connector

EMsnap opened a new pull request, #7610:
URL: https://github.com/apache/inlong/pull/7610

   ### Prepare a Pull Request
   - Fixes #7609 
   
   ### Motivation
   
   [INLONG-7609][Sort][Feature] Add audit for kafka source connector
   
   ### Modifications
   
   [INLONG-7609][Sort][Feature] Add audit for kafka source connector
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7610:
URL: https://github.com/apache/inlong/pull/7610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on a diff in pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7610:
URL: https://github.com/apache/inlong/pull/7610#discussion_r1136459489


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   the scope of sort-format-base in connector-base is provided



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on a diff in pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7610:
URL: https://github.com/apache/inlong/pull/7610#discussion_r1136459489


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   the scope of sort-format-base in connector-base is provided



##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   The compilation will fail since it depences on sort-format-base



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on a diff in pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7610:
URL: https://github.com/apache/inlong/pull/7610#discussion_r1136485151


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   The format-base in connector-base is provided scoped, I changed to compile then



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on a diff in pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #7610:
URL: https://github.com/apache/inlong/pull/7610#discussion_r1135617691


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   you remove it in pulsar pom file when you move this class file
   ```
     <dependency>
               <groupId>org.apache.inlong</groupId>
               <artifactId>sort-format-base</artifactId>
               <version>${project.version}</version>
               <scope>provided</scope>
           </dependency>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong commented on a diff in pull request #7610: [INLONG-7609][Sort] Add audit for Kafka source connector

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #7610:
URL: https://github.com/apache/inlong/pull/7610#discussion_r1136508755


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java:
##########
@@ -15,10 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.inlong.sort.pulsar.withoutadmin;

Review Comment:
   > The format-base in connector-base is provided scoped, I changed to compile then
   
   @EMsnap kafka pom file also add it. You also need remove it.
   ```
     <dependency>
               <groupId>org.apache.inlong</groupId>
               <artifactId>sort-format-base</artifactId>
               <version>${project.version}</version>
               <scope>provided</scope>
           </dependency>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org