[GitHub] [hive] saihemanth-cloudera commented on a diff in pull request #4028: HIVE-25032: Optimise PartitionManagementTask

["saihemanth-cloudera (via GitHub)" <gi...@apache.org>]

saihemanth-cloudera commented on code in PR #4028:
URL: https://github.com/apache/hive/pull/4028#discussion_r1105360251


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -2174,6 +2174,22 @@ List<Partition> dropPartitions(String catName, String dbName, String tblName,
                                  PartitionDropOptions options)
       throws NoSuchObjectException, MetaException, TException;
 
+  /**
+   * @param catName catalog name
+   * @param dbName Name of the database
+   * @param tblName Name of the table
+   * @param partNames Arrays of partitions to drop
+   * @param options Boolean options for dropping partitions
+   * @return List of Partitions dropped
+   * @throws NoSuchObjectException No partition matches the expression(s), and ifExists was false.
+   * @throws MetaException error access the RDBMS or storage.
+   * @throws TException On failure
+   */
+  List<Partition> dropPartitions(String catName, String dbName, String tblName,
+                                 String[] partNames,

Review Comment:
   Why do we want to declare this as String array? We are anyway using List<String> everywhere, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org