You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2024/01/08 11:47:17 UTC

[PR] [SPARK-46622][CORE] Override `toString` method for `o.a.s.network.shuffledb.StoreVersion` [spark]

LuciferYang opened a new pull request, #44624:
URL: https://github.com/apache/spark/pull/44624

   ### What changes were proposed in this pull request?
   This pr aims to override `toString` method for `o.a.s.network.shuffledb.StoreVersion`
   
   ### Why are the changes needed?
   Avoid displaying 'StoreVersion@hashCode' in the IOException thrown after the checkVersion check fails in RocksDBProvider/LevelDBProvider, show something like:
   
   ```
   cannot read state DB with version org.apache.spark.network.shuffledb.StoreVersion@1f, incompatible with current version org.apache.spark.network.shuffledb.StoreVersion@3e
   ```
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Add new test
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46622][CORE] Override `toString` method for `o.a.s.network.shuffledb.StoreVersion` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44624:
URL: https://github.com/apache/spark/pull/44624#issuecomment-1883378554

   Merged to master for Apache Spark 4.0.0.
   Thank you, @LuciferYang and Mridul.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46622][CORE] Override `toString` method for `o.a.s.network.shuffledb.StoreVersion` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44624: [SPARK-46622][CORE] Override `toString` method for `o.a.s.network.shuffledb.StoreVersion`
URL: https://github.com/apache/spark/pull/44624


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46622][CORE] Override `toString` method for `o.a.s.network.shuffledb.StoreVersion` [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44624:
URL: https://github.com/apache/spark/pull/44624#issuecomment-1884101864

   Thanks @dongjoon-hyun and @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org