[GitHub] timifasubaa commented on a change in pull request #4030: make string conversion use utf8

[GitBox <gi...@apache.org>]

timifasubaa commented on a change in pull request #4030: make string conversion use utf8
URL: https://github.com/apache/incubator-superset/pull/4030#discussion_r155856791
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -1300,9 +1300,9 @@ def get_data(self, df):
             for i, v in ys.iteritems():
                 x = i
                 if isinstance(x, (tuple, list)):
-                    x = ', '.join([str(s) for s in x])
+                    x = ', '.join([str(s.encode('utf8')) for s in x])
 
 Review comment:
   @john-bodley I tried six.text_type but it didn't work. When 'encode()' is called, by default ascii encoding scheme is used so it will break unless utf-8 is specified. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services