You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by kirill-morozov-epam <gi...@git.apache.org> on 2016/08/27 14:59:09 UTC
[GitHub] bigtop pull request #141: BIGTOP-2523. in order to install puppet 3.8 we nee...
GitHub user kirill-morozov-epam opened a pull request:
https://github.com/apache/bigtop/pull/141
BIGTOP-2523. in order to install puppet 3.8 we need to get it from pu\u2026
\u2026ppet repo
https://issues.apache.org/jira/browse/BIGTOP-2523
Incorrect cycle dependency during puppet deployment causes error at Debian 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit 3735c8ebd7aabc6ee0d34e06a0b261f32c615dc2
Author: Artur Papikyan <ar...@epam.com>
Date: 2016-08-26T13:12:42Z
BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #141: BIGTOP-2523. Incorrect cycle dependency during puppet dep...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/141
LGTM! (aside from the formatting fix). Olaf taking a look would be great, but I think it is small enough so we can just go ahead and commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #141: BIGTOP-2523. Incorrect cycle dependency during puppet dep...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/141
I have committed the fix. Thanks for your help guys, please close the PR as you see fit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #141: BIGTOP-2523. Incorrect cycle dependency during puppet dep...
Posted by kirill-morozov-epam <gi...@git.apache.org>.
Github user kirill-morozov-epam commented on the issue:
https://github.com/apache/bigtop/pull/141
This is correct. Artur the author of the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #141: BIGTOP-2523. Incorrect cycle dependency during puppet dep...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/141
I am confused. Who's the author of the patch? The commit shows
```
From: Artur Papikyan <ar...@epam.com>
Date: Fri, 26 Aug 2016 16:12:42 +0300
```
Is this correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #141: BIGTOP-2523. in order to install puppet 3.8 we nee...
Posted by kirill-morozov-epam <gi...@git.apache.org>.
GitHub user kirill-morozov-epam reopened a pull request:
https://github.com/apache/bigtop/pull/141
BIGTOP-2523. in order to install puppet 3.8 we need to get it from pu\u2026
\u2026ppet repo
https://issues.apache.org/jira/browse/BIGTOP-2523
Incorrect cycle dependency during puppet deployment causes error at Debian 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirill-morozov-epam/bigtop BIGTOP-2523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit 3735c8ebd7aabc6ee0d34e06a0b261f32c615dc2
Author: Artur Papikyan <ar...@epam.com>
Date: 2016-08-26T13:12:42Z
BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #141: BIGTOP-2523. Incorrect cycle dependency during pup...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/141#discussion_r76845555
--- Diff: bigtop_toolchain/bin/puppetize.sh ---
@@ -54,8 +54,13 @@ case ${ID}-${VERSION_ID} in
apt-get -y install curl sudo unzip wget puppet software-properties-common
;;
debian-8*)
+ apt-get update
+ apt-get -y install wget
+ # BIGTOP-2523. in order to install puppet 3.8 we need to get it from puppet repo
+ wget -O /tmp/puppetlabs-release-trusty.deb https://apt.puppetlabs.com/puppetlabs-release-trusty.deb && dpkg -i /tmp/puppetlabs-release-trusty.deb
+ rm -f /tmp/puppetlabs-release-trusty.deb
apt-get update
- apt-get -y install curl sudo unzip wget puppet
+ apt-get -y install curl sudo unzip puppet
--- End diff --
this looks like a formatting change, irrelevant to the scope
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #141: BIGTOP-2523. Incorrect cycle dependency during pup...
Posted by kirill-morozov-epam <gi...@git.apache.org>.
Github user kirill-morozov-epam closed the pull request at:
https://github.com/apache/bigtop/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #141: BIGTOP-2523. in order to install puppet 3.8 we nee...
Posted by kirill-morozov-epam <gi...@git.apache.org>.
Github user kirill-morozov-epam closed the pull request at:
https://github.com/apache/bigtop/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---