[GitHub] [spark] allisonwang-db commented on a change in pull request #31984: [SPARK-34884][SQL] Improve DPP evaluation to make filtering side must can broadcast by size or broadcast by hint

[GitBox <gi...@apache.org>]

allisonwang-db commented on a change in pull request #31984:
URL: https://github.com/apache/spark/pull/31984#discussion_r607308559



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -868,7 +868,7 @@ abstract class DynamicPartitionPruningSuiteBase
           |ON f.store_id = s.store_id WHERE s.country = 'DE'
         """.stripMargin)
 
-      checkPartitionPruningPredicate(df, true, false)
+      checkPartitionPruningPredicate(df, false, false)

Review comment:
       @wangyum Why would this PR change this test? This originally can be planned as a subquery duplicate but now it cannot.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org