You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tgravescs <gi...@git.apache.org> on 2016/11/07 15:18:33 UTC

[GitHub] spark pull request #15563: [SPARK-16759][CORE] Add a configuration property ...

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15563#discussion_r86795494
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2551,6 +2551,7 @@ private[util] object CallerContext extends Logging {
      */
     private[spark] class CallerContext(
        from: String,
    +   upstreamCallerContext: Option[String] = None,
    --- End diff --
    
    I'd prefer to see new parameters added as the last param to the class.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org