You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/03/27 14:46:58 UTC

[Bug 54758] New: ConditionalFormattingRule: "stopIfTrue" attribute is missing

https://issues.apache.org/bugzilla/show_bug.cgi?id=54758

            Bug ID: 54758
           Summary: ConditionalFormattingRule: "stopIfTrue" attribute is
                    missing
           Product: POI
           Version: 4.0-dev
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: gg@db.com
    Classification: Unclassified

There is no method to set the "stopIfTrue" attribute in
ConditionalFormattingRule


Solution:

CHANGES IN org.apache.poi.ss.usermodel.ConditionalFormattingRule

ADD:

    /**
     * Sets the "stopIfTrue" attribute
     */
    public void setStopIfTrue(boolean bln);

    /**
     * Unsets the "stopIfTrue" attribute
     */
    public void unsetStopIfTrue();




CHANGES IN org.apache.poi.xssf.usermodel.XSSFConditionalFormattingRule

ADD:

    /**
     * Sets the "stopIfTrue" attribute
     */
    @Override
    public void setStopIfTrue(boolean bln) {
        _cfRule.setStopIfTrue(bln);
    }

    /**
     * Unsets the "stopIfTrue" attribute
     */
    @Override
    public void unsetStopIfTrue() {
        _cfRule.unsetStopIfTrue();
    }



CHANGES IN org.apache.poi.hssf.usermodel.HSSFConditionalFormattingRule

ADD:

    /**
     * Sets the "stopIfTrue" attribute
     */
    @Override
    public void setStopIfTrue(boolean bln) {
        throw new UnsupportedOperationException("Not supported yet.");
    }

    /**
     * Unsets the "stopIfTrue" attribute
     */
    @Override
    public void unsetStopIfTrue() {
        throw new UnsupportedOperationException("Not supported yet.");
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54758] [PATCH] ConditionalFormattingRule: "stopIfTrue" attribute is missing

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54758

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #2 from Nick Burch <ap...@gagravarr.org> ---
Patch looks good to apply

One thing that might be good is to create a file in excel conditional
formatting but not this rule, save, then enable stop if true, save, and then
diff the BiffViewer output to try to see what record(s) get set/changed.
Hopefully that will show what (little...) is needed to implement for hssf too!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54758] ConditionalFormattingRule: "stopIfTrue" attribute is missing

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54758

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominik.stadler@gmx.at

--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
Created attachment 30325
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30325&action=edit
Simple patch for the changes proposed in this bug

A patch adding the changes mentioned in this bug together with some simple unit
tests to at least cover the new code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54758] [PATCH] ConditionalFormattingRule: "stopIfTrue" attribute is missing

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54758

liny <in...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |innocentliny@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54758] [PATCH] ConditionalFormattingRule: "stopIfTrue" attribute is missing

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54758

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ConditionalFormattingRule:  |[PATCH]
                   |"stopIfTrue" attribute is   |ConditionalFormattingRule:
                   |missing                     |"stopIfTrue" attribute is
                   |                            |missing

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org