[GitHub] [airflow] bbovenzi commented on a diff in pull request #25011: Add dataset events to dataset api

[GitBox <gi...@apache.org>]

bbovenzi commented on code in PR #25011:
URL: https://github.com/apache/airflow/pull/25011#discussion_r920500554


##########
airflow/api_connexion/endpoints/dataset_endpoint.py:
##########
@@ -59,3 +61,28 @@ def get_datasets(
     query = apply_sorting(query, order_by, {}, allowed_filter_attrs)
     datasets = query.offset(offset).limit(limit).all()
     return dataset_collection_schema.dump(DatasetCollection(datasets=datasets, total_entries=total_entries))
+
+
+@security.requires_access([(permissions.ACTION_CAN_READ, permissions.RESOURCE_DATASET)])
+@provide_session
+@format_parameters({'limit': check_limit})
+def get_dataset_events(
+    id, *, limit: int, offset: int = 0, order_by: str = "created_at", session: Session = NEW_SESSION

Review Comment:
   instead of just ordering, it may be useful to be able to filter by a dag_id



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org