[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3254: purge duplicate method : isDerivedColumnName

[GitBox <gi...@apache.org>]

terrymanu commented on issue #3254: purge duplicate method : isDerivedColumnName
URL: https://github.com/apache/incubator-shardingsphere/pull/3254#issuecomment-541659077
 
 
   I see the code carefully, it is different with that 2 method.
   
   In method `isDerivedColumnName`, it use `DerivedColumn.values()`;
   In method `isDerivedColumn`, it use `DerivedColumn.getValues()`;
   
   The different of `DerivedColumn.values()` and `DerivedColumn.getValues()` is deal with AGGREGATION_DISTINCT_DERIVED.
   
   So we cannot just merge those 2 methods, need refactor further. So I just close this pr, please keep focus is you want to continue refactor this method, thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services