You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2009/07/22 00:25:14 UTC

[jira] Created: (DIRSERVER-1384) Abandonned requests are not abandonned...

Abandonned requests are not abandonned...
-----------------------------------------

                 Key: DIRSERVER-1384
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1384
             Project: Directory ApacheDS
          Issue Type: Bug
    Affects Versions: 1.5.4
            Reporter: Emmanuel Lecharny
            Priority: Critical
             Fix For: 1.5.5


The AbandonRequest is correctly handled, but the way the search is now handled makes the abandon request to be ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (DIRSERVER-1384) Abandonned requests are not abandonned...

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734095#action_12734095 ] 

Emmanuel Lecharny commented on DIRSERVER-1384:
----------------------------------------------

I think that the way we use MINA (ie, with an ExecutorFilter) forbid us to send two requests and get them executed on the same session in //

The abandonRequest is always treated after the other request (the one we want to abandon) is completely processed. (To be double checked)

> Abandonned requests are not abandonned...
> -----------------------------------------
>
>                 Key: DIRSERVER-1384
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1384
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Priority: Critical
>             Fix For: 1.5.5
>
>
> The AbandonRequest is correctly handled, but the way the search is now handled makes the abandon request to be ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (DIRSERVER-1384) Abandonned requests are not abandonned...

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734845#action_12734845 ] 

Emmanuel Lecharny commented on DIRSERVER-1384:
----------------------------------------------

Ok, using an UnorderedThreadPoolExecutor, the Abandon Request gets correctly executed.

If tests are passing OK, I will commit the fix.

The Ldap Client API has been fixed to correctly handle the very same problem on the client size, ie all the response being hold until the last one arrives. The same solution has been applied (Filtering events and using an UnorderedThreadPoolExcecutor).

> Abandonned requests are not abandonned...
> -----------------------------------------
>
>                 Key: DIRSERVER-1384
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1384
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Priority: Critical
>             Fix For: 1.5.5
>
>
> The AbandonRequest is correctly handled, but the way the search is now handled makes the abandon request to be ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (DIRSERVER-1384) Abandonned requests are not abandonned...

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRSERVER-1384.
------------------------------------------

    Resolution: Fixed

Fixed with 
http://svn.apache.org/viewvc?rev=797289&view=rev
http://svn.apache.org/viewvc?rev=797292&view=rev

> Abandonned requests are not abandonned...
> -----------------------------------------
>
>                 Key: DIRSERVER-1384
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1384
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Priority: Critical
>             Fix For: 1.5.5
>
>
> The AbandonRequest is correctly handled, but the way the search is now handled makes the abandon request to be ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (DIRSERVER-1384) Abandonned requests are not abandonned...

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRSERVER-1384.
----------------------------------------


> Abandonned requests are not abandonned...
> -----------------------------------------
>
>                 Key: DIRSERVER-1384
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1384
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Priority: Critical
>             Fix For: 1.5.5
>
>
> The AbandonRequest is correctly handled, but the way the search is now handled makes the abandon request to be ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (DIRSERVER-1384) Abandonned requests are not abandonned...

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734821#action_12734821 ] 

Emmanuel Lecharny commented on DIRSERVER-1384:
----------------------------------------------

So after half a day investingating this issue, here is what I found :
- The way the MINA exectoruFilter works makes it impossible for the AbandonRequest to be processed unless the previous SearchRequest is fully processed, which is insane.
- there were a hell of a bigger problem, though : as we were blocked in the executor until the SearchRequest was totally processed, all the responses were enqueued. That means we had thousands of SearchResultEntries stacked somewhere, waiting for the SR to return. That explains why Kiran had an OOM with 10000 searches, as the comment in the tests stated  :

        // I tried with 10000 entries but only to encounter a OOM :(
        // TODO test this with higher number of entries to actually let the server abort
        // the operation
- This could have led to fast OOM for huge requests. The way to fix that was to simply modifiy the Executor in order to only filter the MESSAGE_RECEIVED, so that the WriteRequest are send back to the client asap.
- Know, we still have the problem about the abandonRequest which can't be processed while the SearchRequest is not finished. May be using an UnorderedThreadPoolExecutor can help ?

> Abandonned requests are not abandonned...
> -----------------------------------------
>
>                 Key: DIRSERVER-1384
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1384
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Priority: Critical
>             Fix For: 1.5.5
>
>
> The AbandonRequest is correctly handled, but the way the search is now handled makes the abandon request to be ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.