You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "biyuhao (GitHub)" <gi...@apache.org> on 2019/01/17 05:44:33 UTC
[GitHub] [incubator-dubbo-ops] biyuhao opened pull request #249:
Tweak ZookeeperConfiguration
### brief changes
- Add null parameter check for `key` and `path`
- Return false if exception thrown in `zkClient.delete().forPath(path);`
- Remove unused import which may introduce compile warning `import java.security.acl.Group;`
- Add unit test for ZookeeperConfiguration #216
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/249 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #249:
Tweak ZookeeperConfiguration
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=h1) Report
> Merging [#249](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/d3c76b125efd7e6ecee3f77805208867b7e4064e?src=pr&el=desc) will **increase** coverage by `1.29%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #249 +/- ##
============================================
+ Coverage 1.45% 2.74% +1.29%
- Complexity 28 48 +20
============================================
Files 85 85
Lines 3446 3457 +11
Branches 547 547
============================================
+ Hits 50 95 +45
+ Misses 3395 3355 -40
- Partials 1 7 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/registry/config/impl/ZookeeperConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vcmVnaXN0cnkvY29uZmlnL2ltcGwvWm9va2VlcGVyQ29uZmlndXJhdGlvbi5qYXZh) | `71.42% <83.33%> (+71.42%)` | `20 <11> (+20)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=footer). Last update [d3c76b1...f4a2846](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/249 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #249:
Tweak ZookeeperConfiguration
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/249 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #249:
Tweak ZookeeperConfiguration
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=h1) Report
> Merging [#249](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/d3c76b125efd7e6ecee3f77805208867b7e4064e?src=pr&el=desc) will **increase** coverage by `1.29%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #249 +/- ##
============================================
+ Coverage 1.45% 2.74% +1.29%
- Complexity 28 48 +20
============================================
Files 85 85
Lines 3446 3457 +11
Branches 547 547
============================================
+ Hits 50 95 +45
+ Misses 3395 3355 -40
- Partials 1 7 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/registry/config/impl/ZookeeperConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vcmVnaXN0cnkvY29uZmlnL2ltcGwvWm9va2VlcGVyQ29uZmlndXJhdGlvbi5qYXZh) | `71.42% <83.33%> (+71.42%)` | `20 <11> (+20)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=footer). Last update [d3c76b1...f4a2846](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/249?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/249 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org