[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #297: Simplify syslog

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on issue #297: Simplify syslog
URL: https://github.com/apache/incubator-nuttx/pull/297#issuecomment-587482647
 
 
   > This seems to depend on the serial device being the console and upon the syslog device being the serial console. That is not always the case. I don't understand the change fully. What I see does not appear to be correct.
   > 
   > Most of the commits look good, basically removing RAM and SYSLOG consoles. and serial lowconsole. But I don't understand why the serial initializatin logic was removed. That does not make sense to me.
   > 
   
   @patacongo do you mean this patch?
   https://github.com/apache/incubator-nuttx/pull/297/commits/9dd2bf7cd3bad9337a989ccae7b5b39a71e30ec1:
   arch/z80: Remove z80_lowserial_initialize related stuff
   
   since nobody call this function at all
   
   > It would be nice if we could divide this up into separate changes and not hold up the good changes based on some that seem not so good (but perhaps I don't understand them).
   
   Could you point out which patch isn't good than I can remove it from patchset or make more explanation?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services