You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/10 19:34:47 UTC
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal
codecov-commenter commented on pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642214083
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=h1) Report
> Merging [#3035](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **decrease** coverage by `36.37%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3035 +/- ##
============================================
- Coverage 45.66% 9.29% -36.38%
+ Complexity 9296 1700 -7596
============================================
Files 1956 1960 +4
Lines 74397 74487 +90
Branches 8247 8257 +10
============================================
- Hits 33977 6923 -27054
- Misses 37242 66888 +29646
+ Partials 3178 676 -2502
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `1.89% <0.00%> (-5.25%)` | `1.00 <0.00> (-8.00)` | |
| [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-18.81%)` | `0.00 <0.00> (-15.00)` | |
| [...pache/gobblin/metrics/MetricReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvTWV0cmljUmVwb3J0ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/gobblin/metrics/MultiReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvTXVsdGlSZXBvcnRlckV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...a/org/apache/gobblin/metrics/ReporterSinkType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvUmVwb3J0ZXJTaW5rVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../java/org/apache/gobblin/metrics/ReporterType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvUmVwb3J0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...blin/runtime/services/MetricsReportingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc2VydmljZXMvTWV0cmljc1JlcG9ydGluZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `0.00% <0.00%> (-2.71%)` | `0.00 <0.00> (-1.00)` | |
| ... and [1042 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=footer). Last update [31f2ef1...9007371](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org