You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/03/16 10:47:40 UTC

[GitHub] carbondata pull request #2069: [CARBONDATA-2224][File Level Reader Support] ...

GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2069

    [CARBONDATA-2224][File Level Reader Support] Refactoring of #2055

    Review comment fixes and refactoring of #2055 
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata carbonfile_master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2069.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2069
    
----
commit 168b92cb51b39a4afeacd1e4146222a7fd000ec3
Author: Ajantha-Bhat <aj...@...>
Date:   2018-03-16T10:36:04Z

    * Refactoring Review comment fixes for the PR:2055

----


---

[GitHub] carbondata issue #2069: [WIP][CARBONDATA-2224][File Level Reader Support] Re...

Posted by ajantha-bhat <gi...@git.apache.org>.

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2069
  
    retest this please.


---

[GitHub] carbondata pull request #2069: [WIP][CARBONDATA-2224][File Level Reader Supp...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2069#discussion_r175339518
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ---
    @@ -826,8 +826,8 @@ public boolean isExternalTable() {
         return external != null && external.equalsIgnoreCase("true");
       }
     
    -  public boolean isFileLevelExternalTable() {
    -    String external = tableInfo.getFactTable().getTableProperties().get("_filelevelexternal");
    +  public boolean isFileLevelFormat() {
    +    String external = tableInfo.getFactTable().getTableProperties().get("_filelevelformat");
    --- End diff --
    
    Please raise another PR to change the table property from `_filelevelformat` to `fileformat`.
    In future, CarbonTable can be any format, it can be carbonfile or parquet, orc, etc.


---

[GitHub] carbondata issue #2069: [WIP][CARBONDATA-2224][File Level Reader Support] Re...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2069
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3938/



---

[GitHub] carbondata issue #2069: [CARBONDATA-2224][File Level Reader Support] Refacto...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2069
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3946/



---

[GitHub] carbondata issue #2069: [WIP][CARBONDATA-2224][File Level Reader Support] Re...

Posted by ajantha-bhat <gi...@git.apache.org>.

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2069
  
    retest this please


---

[GitHub] carbondata pull request #2069: [WIP][CARBONDATA-2224][File Level Reader Supp...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2069#discussion_r175339069
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java ---
    @@ -0,0 +1,530 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.hadoop.api;
    +
    +import java.io.ByteArrayInputStream;
    +import java.io.DataInputStream;
    +import java.io.IOException;
    +import java.lang.reflect.Constructor;
    +import java.util.ArrayList;
    +import java.util.BitSet;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datamap.DataMapChooser;
    +import org.apache.carbondata.core.datamap.DataMapLevel;
    +import org.apache.carbondata.core.datamap.Segment;
    +import org.apache.carbondata.core.datamap.dev.expr.DataMapExprWrapper;
    +import org.apache.carbondata.core.exception.InvalidConfigurationException;
    +import org.apache.carbondata.core.indexstore.ExtendedBlocklet;
    +import org.apache.carbondata.core.indexstore.PartitionSpec;
    +import org.apache.carbondata.core.indexstore.blockletindex.BlockletDataMapFactory;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +import org.apache.carbondata.core.metadata.ColumnarFormatVersion;
    +import org.apache.carbondata.core.metadata.schema.PartitionInfo;
    +import org.apache.carbondata.core.metadata.schema.partition.PartitionType;
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable;
    +import org.apache.carbondata.core.metadata.schema.table.TableInfo;
    +import org.apache.carbondata.core.mutate.UpdateVO;
    +import org.apache.carbondata.core.scan.expression.Expression;
    +import org.apache.carbondata.core.scan.filter.SingleTableProvider;
    +import org.apache.carbondata.core.scan.filter.TableProvider;
    +import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf;
    +import org.apache.carbondata.core.scan.model.QueryModel;
    +import org.apache.carbondata.core.stats.QueryStatistic;
    +import org.apache.carbondata.core.stats.QueryStatisticsConstants;
    +import org.apache.carbondata.core.stats.QueryStatisticsRecorder;
    +import org.apache.carbondata.core.util.CarbonProperties;
    +import org.apache.carbondata.core.util.CarbonTimeStatisticsFactory;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +import org.apache.carbondata.core.util.DataTypeConverter;
    +import org.apache.carbondata.core.util.DataTypeConverterImpl;
    +import org.apache.carbondata.core.util.path.CarbonTablePath;
    +import org.apache.carbondata.hadoop.CarbonInputSplit;
    +import org.apache.carbondata.hadoop.CarbonMultiBlockSplit;
    +import org.apache.carbondata.hadoop.CarbonProjection;
    +import org.apache.carbondata.hadoop.CarbonRecordReader;
    +import org.apache.carbondata.hadoop.readsupport.CarbonReadSupport;
    +import org.apache.carbondata.hadoop.readsupport.impl.DictionaryDecodeReadSupport;
    +import org.apache.carbondata.hadoop.util.CarbonInputFormatUtil;
    +import org.apache.carbondata.hadoop.util.ObjectSerializationUtil;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.LocalFileSystem;
    +import org.apache.hadoop.fs.Path;
    +import org.apache.hadoop.mapreduce.InputSplit;
    +import org.apache.hadoop.mapreduce.JobContext;
    +import org.apache.hadoop.mapreduce.RecordReader;
    +import org.apache.hadoop.mapreduce.TaskAttemptContext;
    +import org.apache.hadoop.mapreduce.lib.input.FileInputFormat;
    +import org.apache.hadoop.mapreduce.lib.input.FileSplit;
    +import org.apache.hadoop.mapreduce.security.TokenCache;
    +
    +/**
    + * Input format of CarbonData file.
    --- End diff --
    
    change comment: 
    `Base class for carbondata input format, there are two input format implementation:
    1. CarbonFileInputFormat: describe this format
    2. CarbonTableInputFormat: describe this format
    `


---

[GitHub] carbondata issue #2069: [CARBONDATA-2224][File Level Reader Support] Refacto...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2069
  
    LGTM


---