You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Arsnael (via GitHub)" <gi...@apache.org> on 2025/03/13 07:54:39 UTC

[PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Arsnael opened a new pull request, #2672:
URL: https://github.com/apache/james-project/pull/2672

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2672:
URL: https://github.com/apache/james-project/pull/2672#issuecomment-2724048611

   => https://github.com/apache/james-jdkim/pull/19


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2672:
URL: https://github.com/apache/james-project/pull/2672#issuecomment-2756998641

   Jspf has been successfully upgraded. Jdkim will need a new release. 
   
   Closing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2672:
URL: https://github.com/apache/james-project/pull/2672#issuecomment-2723941170

   > shade the all commons-codec lib without excluding things to avoid this kind of issue in the future
   
   JDKIM is used by other projects than James and forcing everybody to align on our commons-codec version is not reasonnable. THus I am more in favor of shading as that given lib is very small.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael closed pull request #2672: [UPGRADE] JSPF and JDKIM to latest release versions
URL: https://github.com/apache/james-project/pull/2672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2672:
URL: https://github.com/apache/james-project/pull/2672#issuecomment-2723849295

   Let's try getting jspf upgrade at least first => https://github.com/apache/james-project/pull/2675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [UPGRADE] JSPF and JDKIM to latest release versions [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2672:
URL: https://github.com/apache/james-project/pull/2672#issuecomment-2723843886

   DKIM tests failing : 
   
   org/apache/james/jdkim/codec/binary/BinaryCodec
   
   When looking at jdkim code, if i understand correctly we shade the commons-codec lib to bundle it in the final jar on an other path  `org.apache.james.dkim.codec` by sizing it down to base64 related code only and excluding the rest. However, after upgrading the commons-codec lib to 1.17.1, it seems it changes things a bit around and we need BinaryCodec now for base64 encoding code. But BinaryCodec is excluded from this shade:
   
    =>https://github.com/apache/james-jdkim/blob/master/main/pom.xml#L117
   
   By removing that exclude line, recompiling jdkim locally and applying it to james, tests are green.
   
   I see few different approaches here:
   
   - patch jdkim lib by removing that exclude on BinaryCodec
   - shade the all commons-codec lib without excluding things to avoid this kind of issue in the future
   - remove the shade and have commons-codec aligned in projects using jdkim like james
   
   I fear we need to go for an other release of jdkim though to nicely fix this.
   
   Will open a PR for jspf upgrade alone at least but I'm opened to other suggestions though if any


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org