You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/07/16 19:34:01 UTC
Review Request 60900: Updated Python linter to work with multiple
directories.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/
-----------------------------------------------------------
Review request for mesos, Eric Chung and Kevin Klues.
Repository: mesos
Description
-------
This allows us to have different Pylint configurations
depending on the directory we lint. This will be useful
in the future to lint our standard Python packages and
the list of scripts in support/ differently.
Diffs
-----
src/python/cli_new/pylint.config
support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
Diff: https://reviews.apache.org/r/60900/diff/1/
Testing
-------
Updated a file in src/python/cli_new and checked that the linter was working as before.
Thanks,
Armand Grillet
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review180749
-----------------------------------------------------------
support/mesos-style.py
Line 357 (original), 372 (patched)
<https://reviews.apache.org/r/60900/#comment255960>
this will crap out because self.source_dirs has been changed to a dict
- Eric Chung
On July 16, 2017, 7:34 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 16, 2017, 7:34 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
>
>
> Diff: https://reviews.apache.org/r/60900/diff/1/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review180752
-----------------------------------------------------------
support/mesos-style.py
Lines 309-319 (original), 325-335 (patched)
<https://reviews.apache.org/r/60900/#comment255965>
this can be done with less duplication:
```
process = subprocess.Popen(
[('. {virtualenv_dir}/bin/activate;'
' PYTHONPATH={lib_dir}:{bin_dir} pylint'
' --rcfile={pylint} --ignore={ignore} {files}').
format(files=source_files,
**source_config)],
shell=True, stdout=subprocess.PIPE)
```
- Eric Chung
On July 16, 2017, 7:34 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 16, 2017, 7:34 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
>
>
> Diff: https://reviews.apache.org/r/60900/diff/1/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review180645
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60899, 60900]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 16, 2017, 7:34 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 16, 2017, 7:34 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
>
>
> Diff: https://reviews.apache.org/r/60900/diff/1/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review180823
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Chung
On July 18, 2017, 5:31 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
>
>
> Diff: https://reviews.apache.org/r/60900/diff/2/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review181259
-----------------------------------------------------------
Bad patch!
Reviews applied: [60900, 60899]
Failed command: python support/apply-reviews.py -n -r 60900
Error:
error: patch failed: support/mesos-style.py:279
error: support/mesos-style.py: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/179/console
- Mesos Reviewbot Windows
On July 18, 2017, 5:31 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
>
>
> Diff: https://reviews.apache.org/r/60900/diff/2/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review181188
-----------------------------------------------------------
I made some modifications to this patch on my own branch:
https://github.com/klueska-mesosphere/mesos/commit/cae8eee14692bbbf42b9c06ab892123ea8410c7e
Take a look and see what you think.
- Kevin Klues
On July 18, 2017, 5:31 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 5:31 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
>
>
> Diff: https://reviews.apache.org/r/60900/diff/2/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review185982
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On July 29, 2017, 2:15 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60900/
> -----------------------------------------------------------
>
> (Updated July 29, 2017, 2:15 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to have different Pylint configurations
> depending on the directory we lint. This will be useful
> in the future to lint our standard Python packages and
> the list of scripts in support/ differently.
>
>
> Diffs
> -----
>
> src/python/cli_new/pylint.config
> support/mesos-style.py 77a4e855a5595b3933fd271919a56a869378b742
>
>
> Diff: https://reviews.apache.org/r/60900/diff/4/
>
>
> Testing
> -------
>
> Updated a file in src/python/cli_new and checked that the linter was working as before.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/
-----------------------------------------------------------
(Updated July 29, 2017, 2:15 p.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Updated following comment.
Repository: mesos
Description
-------
This allows us to have different Pylint configurations
depending on the directory we lint. This will be useful
in the future to lint our standard Python packages and
the list of scripts in support/ differently.
Diffs (updated)
-----
src/python/cli_new/pylint.config
support/mesos-style.py 77a4e855a5595b3933fd271919a56a869378b742
Diff: https://reviews.apache.org/r/60900/diff/3/
Changes: https://reviews.apache.org/r/60900/diff/2-3/
Testing
-------
Updated a file in src/python/cli_new and checked that the linter was working as before.
Thanks,
Armand Grillet
Re: Review Request 60900: Updated Python linter to work with multiple
directories.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/
-----------------------------------------------------------
(Updated July 18, 2017, 5:31 a.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Fixed issues.
Repository: mesos
Description
-------
This allows us to have different Pylint configurations
depending on the directory we lint. This will be useful
in the future to lint our standard Python packages and
the list of scripts in support/ differently.
Diffs (updated)
-----
src/python/cli_new/pylint.config
support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
Diff: https://reviews.apache.org/r/60900/diff/2/
Changes: https://reviews.apache.org/r/60900/diff/1-2/
Testing
-------
Updated a file in src/python/cli_new and checked that the linter was working as before.
Thanks,
Armand Grillet