You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/10 18:25:40 UTC

[GitHub] [beam] veblush commented on a change in pull request #13846: Removed conscrypt from a shaded dataflow-worker jar

veblush commented on a change in pull request #13846:
URL: https://github.com/apache/beam/pull/13846#discussion_r573969354



##########
File path: runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
##########
@@ -213,7 +206,7 @@ dependencies {
     compile project(":sdks:java:fn-execution")
     compile project(path: ":runners:google-cloud-dataflow-java:worker:windmill", configuration: "shadow")
     shadow library.java.vendored_guava_26_0_jre
-    compile "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
+    compileOnly "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"

Review comment:
       Yep that's a good idea. Done!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org