You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/19 14:57:36 UTC
[GitHub] [spark] sev7e0 opened a new pull request #26951:
[SPARK-30304][CORE]When the specified shufflemanager is incorrect,
print the prompt.
sev7e0 opened a new pull request #26951: [SPARK-30304][CORE]When the specified shufflemanager is incorrect, print the prompt.
URL: https://github.com/apache/spark/pull/26951
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
During the instantiation of the specified `ShuffleManager`, if the configuration is wrong, whether the log can print some tips.
before:
```log
java.lang.ClassNotFoundException: hash
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at org.apache.spark.util.Utils$.classForName(Utils.scala:206)
at org.apache.spark.SparkEnv$.instantiateClass$1(SparkEnv.scala:274)
at org.apache.spark.SparkEnv$.create(SparkEnv.scala:338)
at org.apache.spark.SparkEnv$.createDriverEnv(SparkEnv.scala:188)
at org.apache.spark.SparkContext.createSparkEnv(SparkContext.scala:277)
at org.apache.spark.SparkContext.<init>(SparkContext.scala:462)
at org.apache.spark.SparkContext.<init>(SparkContext.scala:131)
at org.apache.spark.SortShuffleSuite.$anonfun$new$1(SortShuffleSuite.scala:67)
at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
```
Now it's not just printing out stack exceptions, but also printing error prompt logs.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It is convenient to quickly locate problems through logs.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add test in `SortShuffleSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sev7e0 commented on issue #26951: [SPARK-30304][CORE]When
the specified shufflemanager is incorrect, print the prompt.
Posted by GitBox <gi...@apache.org>.
sev7e0 commented on issue #26951: [SPARK-30304][CORE]When the specified shufflemanager is incorrect, print the prompt.
URL: https://github.com/apache/spark/pull/26951#issuecomment-568161025
> Meh, maybe. This is already telling you the class you specified doesn't exist.
Well, as you said, it's just that there's no obvious mention in the log of where the error occurred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sev7e0 closed pull request #26951: [SPARK-30304][CORE]When
the specified shufflemanager is incorrect, print the prompt.
Posted by GitBox <gi...@apache.org>.
sev7e0 closed pull request #26951: [SPARK-30304][CORE]When the specified shufflemanager is incorrect, print the prompt.
URL: https://github.com/apache/spark/pull/26951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #26951: [SPARK-30304][CORE]When
the specified shufflemanager is incorrect, print the prompt.
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #26951: [SPARK-30304][CORE]When the specified shufflemanager is incorrect, print the prompt.
URL: https://github.com/apache/spark/pull/26951#issuecomment-567942662
Meh, maybe. This is already telling you the class you specified doesn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org