You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by "Ion CERTEJAN (JIRA)" <ji...@apache.org> on 2008/11/15 10:10:56 UTC
[jira] Created: (LOG4PHP-21) Incorrect params passed in
set_include_path
Incorrect params passed in set_include_path
-------------------------------------------
Key: LOG4PHP-21
URL: https://issues.apache.org/jira/browse/LOG4PHP-21
Project: Log4php
Issue Type: Bug
Environment: Win XP, PHP 5.2.5, Maven 2.0.9, PHPUnit 3.2.17, Log4php checked out from svn head as of Nov 14th 2008
Reporter: Ion CERTEJAN
In file:
log4php/trunk/src/test/php/phpunit.php
the line (line #33):
set_include_path(LOG4PHP_DIR.':'.get_include_path());
should be replaced with:
set_include_path(LOG4PHP_DIR.PATH_SEPARATOR.get_include_path());
according to http://www.php.net/manual/en/function.set-include-path.php.
Tests failed on my system because my PATH_SEPARATOR is defined as ';' (semicolon)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Closed: (LOG4PHP-21) Incorrect params passed in set_include_path
Posted by Knut Urdalen <kn...@php.no>.
Gavin wrote:
> So your log message for the above issue correctly ties in to the Jira Issue
> :-
>
> Log: fixed #LOG4PHP-21
>
> but in cases like these I would like to see something like :-
>
> Log: fixed #LOG4PHP-21 - Due to Ion CERTEJAN
>
> or
>
> Log: fixed #LOG4PHP-21 - With thanks to Ion CERTEJAN
>
> Entirely your call, it is one of the things we do at other projects in
> addition to mentions in changes files and contributors sections. It also
> helps create those changes and contributors sections as in the past I've
> often gone back through svn logs to see who has contributed and so can
> mention them properly.
>
> Up to you, and hopefully I won't bang on about it any more :)
>
> (If you agree I'll alter the log message to suit)
>
Sure :) No problemo.
Personally I prefer to note all changes down in a changelog like this:
http://code.google.com/p/yii/source/browse/branches/1.0/CHANGELOG
That way it's very easy to also copy and paste all issues related to
each release together with the release announcement and use it on our
website.
I'm not 100% sure about what format we should use on our changelog, but
we should keep it as simple as this and try to update it together with
our commits.
Knut
RE: [jira] Closed: (LOG4PHP-21) Incorrect params passed in set_include_path
Posted by Gavin <ga...@16degrees.com.au>.
> -----Original Message-----
> From: Knut Urdalen (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, 28 April 2009 5:05 PM
> To: log4php-dev@logging.apache.org
> Subject: [jira] Closed: (LOG4PHP-21) Incorrect params passed in
> set_include_path
>
>
> [ https://issues.apache.org/jira/browse/LOG4PHP-
> 21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Knut Urdalen closed LOG4PHP-21.
> -------------------------------
>
> Resolution: Fixed
>
> Thanks! This is now fixed in trunk. (note that due to the refactoring of
> our unit test suite yesterday phpunit.php is removed in favor of
> phpunit.xml and bootstrap.php).
Thanks Knut for being a busy bee today.
With this patch, Ion pointed out the issue as well as provided a solution to
the problem. Because of refactoring you had to apply it differently.
With all the talk of authors and who did what etc, one of the things I would
like to see moving forward which I mentioned in the other thread, is the
attribution of patches etc in the svn log message.
So your log message for the above issue correctly ties in to the Jira Issue
:-
Log: fixed #LOG4PHP-21
but in cases like these I would like to see something like :-
Log: fixed #LOG4PHP-21 - Due to Ion CERTEJAN
or
Log: fixed #LOG4PHP-21 - With thanks to Ion CERTEJAN
Entirely your call, it is one of the things we do at other projects in
addition to mentions in changes files and contributors sections. It also
helps create those changes and contributors sections as in the past I've
often gone back through svn logs to see who has contributed and so can
mention them properly.
Up to you, and hopefully I won't bang on about it any more :)
(If you agree I'll alter the log message to suit)
Gav...
>
> > Incorrect params passed in set_include_path
> > -------------------------------------------
> >
> > Key: LOG4PHP-21
> > URL: https://issues.apache.org/jira/browse/LOG4PHP-21
> > Project: Log4php
> > Issue Type: Bug
> > Components: Tests
> > Environment: Win XP, PHP 5.2.5, Maven 2.0.9, PHPUnit 3.2.17,
> Log4php checked out from svn head as of Nov 14th 2008
> > Reporter: Ion CERTEJAN
> > Assignee: Knut Urdalen
> > Fix For: 2.0
> >
> >
> > In file:
> > log4php/trunk/src/test/php/phpunit.php
> > the line (line #33):
> > set_include_path(LOG4PHP_DIR.':'.get_include_path());
> > should be replaced with:
> > set_include_path(LOG4PHP_DIR.PATH_SEPARATOR.get_include_path());
> > according to http://www.php.net/manual/en/function.set-include-path.php.
> > Tests failed on my system because my PATH_SEPARATOR is defined as ';'
> (semicolon)
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.557 / Virus Database: 270.12.4/2082 - Release Date: 4/27/2009
> 6:19 AM
[jira] Updated: (LOG4PHP-21) Incorrect params passed in
set_include_path
Posted by "Knut Urdalen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Urdalen updated LOG4PHP-21:
--------------------------------
Component/s: Tests
> Incorrect params passed in set_include_path
> -------------------------------------------
>
> Key: LOG4PHP-21
> URL: https://issues.apache.org/jira/browse/LOG4PHP-21
> Project: Log4php
> Issue Type: Bug
> Components: Tests
> Environment: Win XP, PHP 5.2.5, Maven 2.0.9, PHPUnit 3.2.17, Log4php checked out from svn head as of Nov 14th 2008
> Reporter: Ion CERTEJAN
> Fix For: 2.0
>
>
> In file:
> log4php/trunk/src/test/php/phpunit.php
> the line (line #33):
> set_include_path(LOG4PHP_DIR.':'.get_include_path());
> should be replaced with:
> set_include_path(LOG4PHP_DIR.PATH_SEPARATOR.get_include_path());
> according to http://www.php.net/manual/en/function.set-include-path.php.
> Tests failed on my system because my PATH_SEPARATOR is defined as ';' (semicolon)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (LOG4PHP-21) Incorrect params passed in
set_include_path
Posted by "Knut Urdalen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Urdalen reassigned LOG4PHP-21:
-----------------------------------
Assignee: Knut Urdalen
> Incorrect params passed in set_include_path
> -------------------------------------------
>
> Key: LOG4PHP-21
> URL: https://issues.apache.org/jira/browse/LOG4PHP-21
> Project: Log4php
> Issue Type: Bug
> Components: Tests
> Environment: Win XP, PHP 5.2.5, Maven 2.0.9, PHPUnit 3.2.17, Log4php checked out from svn head as of Nov 14th 2008
> Reporter: Ion CERTEJAN
> Assignee: Knut Urdalen
> Fix For: 2.0
>
>
> In file:
> log4php/trunk/src/test/php/phpunit.php
> the line (line #33):
> set_include_path(LOG4PHP_DIR.':'.get_include_path());
> should be replaced with:
> set_include_path(LOG4PHP_DIR.PATH_SEPARATOR.get_include_path());
> according to http://www.php.net/manual/en/function.set-include-path.php.
> Tests failed on my system because my PATH_SEPARATOR is defined as ';' (semicolon)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LOG4PHP-21) Incorrect params passed in
set_include_path
Posted by "Knut Urdalen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Urdalen closed LOG4PHP-21.
-------------------------------
Resolution: Fixed
Thanks! This is now fixed in trunk. (note that due to the refactoring of our unit test suite yesterday phpunit.php is removed in favor of phpunit.xml and bootstrap.php).
> Incorrect params passed in set_include_path
> -------------------------------------------
>
> Key: LOG4PHP-21
> URL: https://issues.apache.org/jira/browse/LOG4PHP-21
> Project: Log4php
> Issue Type: Bug
> Components: Tests
> Environment: Win XP, PHP 5.2.5, Maven 2.0.9, PHPUnit 3.2.17, Log4php checked out from svn head as of Nov 14th 2008
> Reporter: Ion CERTEJAN
> Assignee: Knut Urdalen
> Fix For: 2.0
>
>
> In file:
> log4php/trunk/src/test/php/phpunit.php
> the line (line #33):
> set_include_path(LOG4PHP_DIR.':'.get_include_path());
> should be replaced with:
> set_include_path(LOG4PHP_DIR.PATH_SEPARATOR.get_include_path());
> according to http://www.php.net/manual/en/function.set-include-path.php.
> Tests failed on my system because my PATH_SEPARATOR is defined as ';' (semicolon)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.