You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2026/10/05 11:27:39 UTC
[PR] SOLR-18502: INSTALLSHARD skips write.lock download [solr]
gerlowskija opened a new pull request, #5026:
URL: https://github.com/apache/solr/pull/5026
https://issues.apache.org/jira/browse/SOLR-18502
# Description
Offline index data directories, such as those used for non-incremental restores or INSTALLSHARD operations, shouldn't really contain "write.lock" files. But they're often present all the same, as users commonly create their offline indices by doing a full directory copy from a running Solr instance.
INSTALLSHARD handles these files gracefully, but it does cause a bit of noise in the logs as the write.lock file doesn't contain the checksum that Solr expects to find by default.
# Solution
This commit adds a tiny check in RestoreCore so that it's exempted from INSTALLSHARD operations and non-incremental restores.
# Tests
See AbstractInstallShardTest. Validating that "write.lock" isn't among the copied files involved a few minor changes to TrackingBackupRepository.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18502: INSTALLSHARD skips write.lock download [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on PR #5026:
URL: https://github.com/apache/solr/pull/5026#issuecomment-6430418394
Interesting, this change reverted on main however back ported to branch_10x few hours ago and now it's failing there.
https://ci-builds.apache.org/job/Solr/job/Solr-Test-10.x/2939/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18502: INSTALLSHARD skips write.lock download [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #5026:
URL: https://github.com/apache/solr/pull/5026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18502: INSTALLSHARD skips write.lock download [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #5026:
URL: https://github.com/apache/solr/pull/5026#issuecomment-6456780568
Ugh; I'll backport the Revert. I cleared the milestone here right now; ideally that would have happened when the Revert happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18502: INSTALLSHARD skips write.lock download [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #5026:
URL: https://github.com/apache/solr/pull/5026#issuecomment-5993743494
(Tests and check pass locally.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org