You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/08/12 12:12:48 UTC

[jira] [Commented] (SQOOP-2452) Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class

    [ https://issues.apache.org/jira/browse/SQOOP-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693259#comment-14693259 ] 

Hudson commented on SQOOP-2452:
-------------------------------

SUCCESS: Integrated in Sqoop2 #866 (See [https://builds.apache.org/job/Sqoop2/866/])
SQOOP-2452: Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class (abe: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3c88f553de57a6fc35bc4e2191bcb58384662d72)
* client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java


> Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class
> ----------------------------------------------------------------------------------
>
>                 Key: SQOOP-2452
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2452
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2452.patch
>
>
> I feel that this one is more of a nit then a real problem, but findbugs is correct that static inner class is better suited because it doesn't need any variables from the parent's class scope.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)