You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/03/26 16:25:40 UTC

[GitHub] [calcite-avatica] asolimando commented on a change in pull request #138: [CALCITE-2489] Order of fields in JavaTypeFactoryImpl#createStructTyp…

asolimando commented on a change in pull request #138:
URL: https://github.com/apache/calcite-avatica/pull/138#discussion_r602429598



##########
File path: core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
##########
@@ -139,15 +134,8 @@ protected Getter createGetter(int ordinal) {
       return list;
     case RECORD:
     case RECORD_PROJECTION:

Review comment:
       I agree, we can unify them (LGTM in your branch)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org