You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/13 12:07:42 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #39050: [SPARK-41412][CONNECT][TESTS] Exclude binary to make the tests to pass with/without ANSI mode

HyukjinKwon opened a new pull request, #39050:
URL: https://github.com/apache/spark/pull/39050

   ### What changes were proposed in this pull request?
   
   This PR is another followup of https://github.com/apache/spark/pull/39034 that, instead, make the tests to pass with/without ANSI mode.
   
   ### Why are the changes needed?
   
   Spark Connect uses isolated Spark session so setting the configuration in PySpark side does not take an effect. Therefore, the test still fails, see https://github.com/apache/spark/actions/runs/3681383627/jobs/6228030132.
   
   We should make the tests pass with/without ANSI mode for now.
   
   ### Does this PR introduce _any_ user-facing change?
   No, test-only
   
   ### How was this patch tested?
   
   Manually tested via:
   
   ```bash
   SPARK_ANSI_SQL_MODE=true ./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_column'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #39050: [SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39050: [SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode
URL: https://github.com/apache/spark/pull/39050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #39050: [SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39050:
URL: https://github.com/apache/spark/pull/39050#issuecomment-1350054310

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #39050: [SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39050:
URL: https://github.com/apache/spark/pull/39050#issuecomment-1350196856

   LGTM + 1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #39050: [SPARK-41412][CONNECT][TESTS] Exclude binary to make the tests to pass with/without ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39050:
URL: https://github.com/apache/spark/pull/39050#issuecomment-1348391053

   cc @amaliujia @zhengruifeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org