[GitHub] [airflow] uranusjr commented on a change in pull request #19787: Bug fix in AWS glue operator when specifying the WorkerType & NumberOfWorkers

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #19787:
URL: https://github.com/apache/airflow/pull/19787#discussion_r755542394



##########
File path: airflow/providers/amazon/aws/hooks/glue.py
##########
@@ -70,11 +70,23 @@ def __init__(
         self.concurrent_run_limit = concurrent_run_limit
         self.script_location = script_location
         self.retry_limit = retry_limit
-        self.num_of_dpus = num_of_dpus
         self.s3_bucket = s3_bucket
         self.role_name = iam_role_name
         self.s3_glue_logs = 'logs/glue-logs/'
         self.create_job_kwargs = create_job_kwargs or {}
+        
+        if "WorkerType" in self.create_job_kwargs and "NumberOfWorkers" in self.create_job_kwargs:

Review comment:
       Probably better to extract these `in` checks. It’d make this more readable. It’s currently difficult to visually parse out the different `in` and `not in` checks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org