[GitHub] [gobblin] vikrambohra commented on a diff in pull request #3587: [GOBBLIN-1731] Enable HiveMetadataWriter to override table schema lit…

[GitBox <gi...@apache.org>]

vikrambohra commented on code in PR #3587:
URL: https://github.com/apache/gobblin/pull/3587#discussion_r999819115


##########
gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java:
##########
@@ -95,7 +95,7 @@ public class AvroUtils {
 
   public static final String AVRO_SUFFIX = ".avro";
 
-  private static final String SCHEMA_CREATION_TIME_KEY = "CreatedOn";
+  public static final String SCHEMA_CREATION_TIME_KEY = "CreatedOn";

Review Comment:
   AvroSchemaUtil.convert in li-iceberg returns a shaded avro schema object so I cannot use AvroUtils.setProperty. Therefore I need to set the SCHEMA_CREATION_TIME_KEY directly on the shaded object and its better to use this Key from AvroUtils rather than create a new Key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org