[GitHub] [flink] becketqin edited a comment on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

[GitBox <gi...@apache.org>]

becketqin edited a comment on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#issuecomment-503452762
 
 
   @aljoscha Thanks for the pointer to the earlier PR. The solution in my mind was slightly different from but pretty similar to what you have in the PR. 
   
   I was thinking that we can have a private constructor that takes both `KafkaSchemaSerializer` and `KeyedSerializationSchema` in the arguments, but one of them will always be null which is guaranteed by the public constructors. So the public constructors will always call this private constructor, but with one of the two serialization schema set to null. Would that address the problem of having duplicate code in the constructors?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services