You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yoshikazu Nojima <ma...@ynojima.net> on 2013/10/23 08:36:24 UTC
Review Request 14868: Bugfix: listNetworks API doesn't return vlan id / VNI
( Virtual Network Identifier in VXLAN )
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14868/
-----------------------------------------------------------
Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Toshiaki Hatano.
Bugs: CLOUDSTACK-4932
https://issues.apache.org/jira/browse/CLOUDSTACK-4932
Repository: cloudstack-git
Description
-------
Issue to resolve:
When listNetworks API is called with root admin account, it must return vlan id, but it returns "N/A".
I tested with the branch "master".
http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html
This patch fixed comparison bug of BroadCastDomainType instance to make this api return vlan id, and made this api returns VNI ( Virtual Network Identifier in VXLAN ) when network is configured to use VXLAN.
Diffs
-----
server/src/com/cloud/api/ApiResponseHelper.java f4ca112
Diff: https://reviews.apache.org/r/14868/diff/
Testing
-------
I confirmed appropriate VLAN ID is returned by listNetworks API, and it is displayed in the "Network"/"Guest networks"/"details" tab in CloudStack WebGUI.
Thanks,
Yoshikazu Nojima
Re: Review Request 14868: CLOUDSTACK-4932: Bugfix: listNetworks API doesn't
return vlan id / VNI ( Virtual Network Identifier in VXLAN )
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14868/#review27781
-----------------------------------------------------------
Commit a6b6fa65facf83444262eb37ca65371a16900a04 in branch refs/heads/master from ynojima
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a6b6fa6 ]
CLOUDSTACK-4932: bugfix : listNetworks API doesn't return VLAN ID (VNI)
Signed-off-by: ynojima <ma...@ynojima.net>
Signed-off-by: Toshiaki Hatano <ha...@haeena.net>
- ASF Subversion and Git Services
On Oct. 23, 2013, 6:38 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14868/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 6:38 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4932
> https://issues.apache.org/jira/browse/CLOUDSTACK-4932
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue to resolve:
> When listNetworks API is called with root admin account, it must return vlan id, but it returns "N/A".
> I tested with the branch "master".
>
> http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html
>
> This patch fixed comparison bug of BroadCastDomainType instance to make this api return vlan id, and made this api returns VNI ( Virtual Network Identifier in VXLAN ) when network is configured to use VXLAN.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java f4ca112
>
> Diff: https://reviews.apache.org/r/14868/diff/
>
>
> Testing
> -------
>
> I confirmed appropriate VLAN ID is returned by listNetworks API, and it is displayed in the "Network"/"Guest networks"/"details" tab in CloudStack WebGUI.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 14868: CLOUDSTACK-4932: Bugfix: listNetworks API doesn't
return vlan id / VNI ( Virtual Network Identifier in VXLAN )
Posted by Toshiaki Hatano <ha...@haeena.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14868/#review27780
-----------------------------------------------------------
Ship it!
Ship It!
- Toshiaki Hatano
On Oct. 23, 2013, 6:38 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14868/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 6:38 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4932
> https://issues.apache.org/jira/browse/CLOUDSTACK-4932
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue to resolve:
> When listNetworks API is called with root admin account, it must return vlan id, but it returns "N/A".
> I tested with the branch "master".
>
> http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html
>
> This patch fixed comparison bug of BroadCastDomainType instance to make this api return vlan id, and made this api returns VNI ( Virtual Network Identifier in VXLAN ) when network is configured to use VXLAN.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java f4ca112
>
> Diff: https://reviews.apache.org/r/14868/diff/
>
>
> Testing
> -------
>
> I confirmed appropriate VLAN ID is returned by listNetworks API, and it is displayed in the "Network"/"Guest networks"/"details" tab in CloudStack WebGUI.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 14868: CLOUDSTACK-4932: Bugfix: listNetworks API doesn't
return vlan id / VNI ( Virtual Network Identifier in VXLAN )
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14868/
-----------------------------------------------------------
(Updated Oct. 23, 2013, 6:38 a.m.)
Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Toshiaki Hatano.
Summary (updated)
-----------------
CLOUDSTACK-4932: Bugfix: listNetworks API doesn't return vlan id / VNI ( Virtual Network Identifier in VXLAN )
Bugs: CLOUDSTACK-4932
https://issues.apache.org/jira/browse/CLOUDSTACK-4932
Repository: cloudstack-git
Description
-------
Issue to resolve:
When listNetworks API is called with root admin account, it must return vlan id, but it returns "N/A".
I tested with the branch "master".
http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html
This patch fixed comparison bug of BroadCastDomainType instance to make this api return vlan id, and made this api returns VNI ( Virtual Network Identifier in VXLAN ) when network is configured to use VXLAN.
Diffs
-----
server/src/com/cloud/api/ApiResponseHelper.java f4ca112
Diff: https://reviews.apache.org/r/14868/diff/
Testing
-------
I confirmed appropriate VLAN ID is returned by listNetworks API, and it is displayed in the "Network"/"Guest networks"/"details" tab in CloudStack WebGUI.
Thanks,
Yoshikazu Nojima