You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 17:38:10 UTC

[GitHub] [airflow] sshah90 commented on pull request #12925: [Loki log handler] - Integration with Grafana Loki

sshah90 commented on pull request #12925:
URL: https://github.com/apache/airflow/pull/12925#issuecomment-858826335


   Hi @ashb, 
   
   > Not including execution_date in the task labels is incorrect -- the execution date is needed to uniquely identify the task instance
   
   I agree, in some instances, you can't uniquely identify the task. However, adding this label (execution_date) would exponentially increase the cardinality in Loki to the point that it would be inoperable. 
   
   This was discussed at great length with the Loki team and therefore, it was intentionally left out. This is also documented [here](https://grafana.com/docs/loki/latest/best-practices/#use-dynamic-labels-sparingly).
   
   > by not including this it means that logs from the task on two separate days would get combined.
   
   This is true however we use `start_time` to filter the log data so that it's not combined when viewing the task logs in the UI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org