You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Jean Jacobs (JIRA)" <ji...@apache.org> on 2009/05/12 15:36:51 UTC

[jira] Created: (SMXCOMP-537) HttpConfiguration not closing file streams in save() and close() methods

HttpConfiguration not closing file streams in save() and close() methods
------------------------------------------------------------------------

                 Key: SMXCOMP-537
                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-537
             Project: ServiceMix Components
          Issue Type: Bug
          Components: servicemix-http
    Affects Versions: servicemix-http-2009.01
            Reporter: Jean Jacobs
            Priority: Minor




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SMXCOMP-537) HttpConfiguration not closing file streams in save() and close() methods

Posted by "Jean Jacobs (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMXCOMP-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51637#action_51637 ] 

Jean Jacobs commented on SMXCOMP-537:
-------------------------------------

I found this problem while I was writing unit tests for the servicemix-http component.  In the test I called the load() method to save configuration information to a file.  At the end of the test I tried to delete the file and it failed.  Once I closed the file streams in the save() and load() methods, I was able to successfully delete the configuration file.  I will attach a patch with the file streams closed.

> HttpConfiguration not closing file streams in save() and close() methods
> ------------------------------------------------------------------------
>
>                 Key: SMXCOMP-537
>                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-537
>             Project: ServiceMix Components
>          Issue Type: Bug
>          Components: servicemix-http
>    Affects Versions: servicemix-http-2009.01
>            Reporter: Jean Jacobs
>            Priority: Minor
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SMXCOMP-537) HttpConfiguration not closing file streams in save() and close() methods

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SMXCOMP-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51654#action_51654 ] 

Claus Ibsen commented on SMXCOMP-537:
-------------------------------------

To be really sure you usually have to close it in a finally block.

> HttpConfiguration not closing file streams in save() and close() methods
> ------------------------------------------------------------------------
>
>                 Key: SMXCOMP-537
>                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-537
>             Project: ServiceMix Components
>          Issue Type: Bug
>          Components: servicemix-http
>    Affects Versions: servicemix-http-2009.01
>            Reporter: Jean Jacobs
>            Priority: Minor
>         Attachments: httpConfiguration.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SMXCOMP-537) HttpConfiguration not closing file streams in save() and close() methods

Posted by "Jean Jacobs (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SMXCOMP-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean Jacobs updated SMXCOMP-537:
--------------------------------

    Attachment: httpConfiguration.patch

Here is a patch with the file streams closed.

> HttpConfiguration not closing file streams in save() and close() methods
> ------------------------------------------------------------------------
>
>                 Key: SMXCOMP-537
>                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-537
>             Project: ServiceMix Components
>          Issue Type: Bug
>          Components: servicemix-http
>    Affects Versions: servicemix-http-2009.01
>            Reporter: Jean Jacobs
>            Priority: Minor
>         Attachments: httpConfiguration.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.