You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "jkmcl (via GitHub)" <gi...@apache.org> on 2023/02/23 05:36:33 UTC

[GitHub] [httpcomponents-core] jkmcl opened a new pull request, #392: Hygiene changes to Deadline

jkmcl opened a new pull request, #392:
URL: https://github.com/apache/httpcomponents-core/pull/392

   Since this is the v5.3 branch which is in alpha stage, is it fine to break binary compatibility by making Deadline.MIN_VALUE and Deadline.MAX_VALUE final and removing the checked exception from Deadline.parse since it cannot be thrown from the method body?
   
   For context regarding MIN_VALUE/MAX_VALUE: https://github.com/apache/httpcomponents-core/pull/355
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c closed pull request #392: Hygiene changes to Deadline

Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c closed pull request #392: Hygiene changes to Deadline
URL: https://github.com/apache/httpcomponents-core/pull/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c commented on pull request #392: Hygiene changes to Deadline

Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #392:
URL: https://github.com/apache/httpcomponents-core/pull/392#issuecomment-1445031389

   @jkmcl This cannot be done until 6.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org