[jira] [Commented] (FLINK-2399) Fail when actor versions don't match

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740695#comment-14740695 ] 

ASF GitHub Bot commented on FLINK-2399:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/945#discussion_r39265532
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java ---
    @@ -192,4 +193,78 @@ public void initializeOnMaster(ClassLoader loader) throws Exception {
     			fail(e.getMessage());
     		}
     	}
    +
    +	/**
    +	 * Verifies failure when the client version is lower than supported.
    +	 */
    +	@Test
    --- End diff --
    
    You can implement the test with `@Test(expected=JobSubmissionException.class)` which checks that the correct exception is produced.


> Fail when actor versions don't match
> ------------------------------------
>
>                 Key: FLINK-2399
>                 URL: https://issues.apache.org/jira/browse/FLINK-2399
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, TaskManager
>    Affects Versions: 0.9, master
>            Reporter: Ufuk Celebi
>            Assignee: Sachin Goel
>            Priority: Minor
>             Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions communicate with each other, for example when an old client (e.g. Flink 0.9) communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the actors and fail if they don't match.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)