You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/28 13:12:21 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1118: MINIFICPP-1492 Fix PCAP build on Linux kernel 5.5 and above
lordgamez opened a new pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1118: MINIFICPP-1492 Fix PCAP build on Linux kernel 5.5 and above
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118#discussion_r659840202
##########
File path: thirdparty/pcap++/Pcap++/src/PcapLiveDevice.cpp
##########
@@ -26,11 +26,6 @@
#endif
#ifdef MAC_OS_X
#include <net/if_dl.h>
-#endif
-
-#if defined(__linux__) && !defined(__GLIBC__)
-#include <linux/sysctl.h>
-#elif !defined(WIN32) && !defined(WINx64)
#include <sys/sysctl.h>
#endif
Review comment:
Yes, that was my intention. If you check the file `sysctl` call is only used on line [682](https://github.com/apache/nifi-minifi-cpp/blob/563848f760dfc679ad86fb476acb36e74142cdac/thirdparty/pcap%2B%2B/Pcap%2B%2B/src/PcapLiveDevice.cpp#L682) and [689](https://github.com/apache/nifi-minifi-cpp/blob/563848f760dfc679ad86fb476acb36e74142cdac/thirdparty/pcap%2B%2B/Pcap%2B%2B/src/PcapLiveDevice.cpp#L689) and those are only part of the MACOS build. The Jira ticket also mentions that this was the same fix in the newer version of the official Pcap++ repository in [this commit](https://github.com/seladb/PcapPlusPlus/commit/f474316b2fcdcd3b2d6ab6143ef4c3b2b5ec9ea8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1118: MINIFICPP-1492 Fix PCAP build on Linux kernel 5.5 and above
Posted by GitBox <gi...@apache.org>.
fgerlits closed pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1118: MINIFICPP-1492 Fix PCAP build on Linux kernel 5.5 and above
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118#discussion_r659820917
##########
File path: thirdparty/pcap++/Pcap++/src/PcapLiveDevice.cpp
##########
@@ -26,11 +26,6 @@
#endif
#ifdef MAC_OS_X
#include <net/if_dl.h>
-#endif
-
-#if defined(__linux__) && !defined(__GLIBC__)
-#include <linux/sysctl.h>
-#elif !defined(WIN32) && !defined(WINx64)
#include <sys/sysctl.h>
#endif
Review comment:
It looks like we add an include `<sys/sysctl.h>` on mac, and remove all includes on linux, because this removal makes the whole block part of `#ifdef MAC_OS_X`. Was this your intention? Am I misunderstanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1118: MINIFICPP-1492 Fix PCAP build on Linux kernel 5.5 and above
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118#discussion_r659820917
##########
File path: thirdparty/pcap++/Pcap++/src/PcapLiveDevice.cpp
##########
@@ -26,11 +26,6 @@
#endif
#ifdef MAC_OS_X
#include <net/if_dl.h>
-#endif
-
-#if defined(__linux__) && !defined(__GLIBC__)
-#include <linux/sysctl.h>
-#elif !defined(WIN32) && !defined(WINx64)
#include <sys/sysctl.h>
#endif
Review comment:
It looks like we add an include `<sys/sysctl.h>` on mac, and remove all includes on linux, because this removal makes the whole block part of `#ifdef MAC_OS_X`. Was this your intention? Am I misunderstanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1118: MINIFICPP-1492 Fix PCAP build on Linux kernel 5.5 and above
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118#discussion_r659840202
##########
File path: thirdparty/pcap++/Pcap++/src/PcapLiveDevice.cpp
##########
@@ -26,11 +26,6 @@
#endif
#ifdef MAC_OS_X
#include <net/if_dl.h>
-#endif
-
-#if defined(__linux__) && !defined(__GLIBC__)
-#include <linux/sysctl.h>
-#elif !defined(WIN32) && !defined(WINx64)
#include <sys/sysctl.h>
#endif
Review comment:
Yes, that was my intention. If you check the file `sysctl` call is only used on line [682](https://github.com/apache/nifi-minifi-cpp/blob/563848f760dfc679ad86fb476acb36e74142cdac/thirdparty/pcap%2B%2B/Pcap%2B%2B/src/PcapLiveDevice.cpp#L682) and [689](https://github.com/apache/nifi-minifi-cpp/blob/563848f760dfc679ad86fb476acb36e74142cdac/thirdparty/pcap%2B%2B/Pcap%2B%2B/src/PcapLiveDevice.cpp#L689) and those are only part of the MACOS build. The Jira ticket also mentions that this was the same fix in the newer version of the official Pcap++ repository in [this commit](https://github.com/seladb/PcapPlusPlus/commit/f474316b2fcdcd3b2d6ab6143ef4c3b2b5ec9ea8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org