[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #9177:
URL: https://github.com/apache/skywalking/pull/9177#discussion_r890724674


##########
docs/en/setup/backend/zipkin-trace.md:
##########
@@ -15,9 +14,35 @@ receiver-zipkin:
     restMaxThreads: ${SW_RECEIVER_ZIPKIN_REST_MAX_THREADS:200}
     restIdleTimeOut: ${SW_RECEIVER_ZIPKIN_REST_IDLE_TIMEOUT:30000}
     restAcceptQueueSize: ${SW_RECEIVER_ZIPKIN_REST_QUEUE_SIZE:0}
-    instanceNameRule: ${SW_RECEIVER_ZIPKIN_INSTANCE_NAME_RULE:[spring.instance_id,node_id]}
     searchableTracesTags: ${SW_ZIPKIN_SEARCHABLE_TAG_KEYS:http.method}
+    # The sample rate precision is 1/10000, should be between 0 and 10000
+    sampleRate: ${SW_ZIPKIN_SAMPLE_RATE:10000}
 ```
 
-NOTE: Zipkin receiver requires `zipkin-elasticsearch` storage implementation to be activated.

Review Comment:
   You need to remove this part in the storage document



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org